Fix 2.0 regression, warnings, v8 memory dealloc hint #917

zbjornson · 2017-05-04T17:17:48Z

Handful of little fixes:

nBytes was wrong as of 1a6dffe, but the tests didn't catch it because they used a square canvas.
Allow alpha and beta version in the test assertions.
Minor: fix shadowing warnings during compilation.
Fix v8 memory dealloc hint. When this function was run, it would have actually hinted to v8 that a massive amount of external memory was being used.

nBytes is height * stride, not width. Introduced by 1a6dffe

Renames a few variables and parameters to avoid shadowing names.

-(unsigned x) is (usually) 2^32 - x. Need to cast to signed first.

LinusU · 2017-05-06T14:24:13Z

Awesome work 👍

LinusU · 2017-05-06T14:25:26Z

Published as 2.0.0-alpha.2

zbjornson added 4 commits May 4, 2017 09:57

Fix regression in toBuffer("raw")

8d0ecb0

nBytes is height * stride, not width. Introduced by 1a6dffe

Allow alpha/beta versions in test suite

f9708bc

src: fix shadowing warnings

dc8964a

Renames a few variables and parameters to avoid shadowing names.

Fix v8 memory dealloc hint

198a61d

-(unsigned x) is (usually) 2^32 - x. Need to cast to signed first.

This was referenced May 4, 2017

Remove source support for node < 4 #918

Merged

Help us test the 2.0 alpha #916

Closed

LinusU merged commit 2db2662 into Automattic:master May 6, 2017

zbjornson deleted the nbytes-regression branch May 18, 2017 20:23

Provide feedback