Skip to content

Upgrade Emscripten version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

brandonpayton
Copy link
Member

Motivation for the change, related issues

Note: This work is continued from a PR started under the WordPress GH org.

There are a couple of reasons for this upgrade:

  1. I am having trouble rebuilding php-wasm on my current system. References to older ubuntu images and emscripten versions has given me trouble.
  2. We want this Emscripten fix from @jeroenpf and @bgrgicak which was first included in Emscripten 3.1.73. This should address https://github.com/Automattic/dotcom-forge/issues/8815.

Implementation details

This PR:

  • Bumps the ubuntu docker image version due to build errors related to missing image. Referencing a newer ubuntu image seemed to fix the "missing image" errors.
  • Bumps Emscripten version
  • Adjusts Playground-specific patches to Emscripten output since the latest breaks that patching.

Testing Instructions (or ideally a Blueprint)

  • CI

@brandonpayton brandonpayton added the bug Something isn't working label Jan 14, 2025
@brandonpayton brandonpayton self-assigned this Jan 14, 2025
@brandonpayton
Copy link
Member Author

This PR needs a bit more work to fix patches Emscripten build output. I hope to work on that tomorrow.

@brandonpayton
Copy link
Member Author

Closing. This is the wrong place for this work.

@brandonpayton brandonpayton deleted the upgrade-emscripten-version branch January 15, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant