-
Notifications
You must be signed in to change notification settings - Fork 2k
Framework: Upgrade to react-redux v5 #9707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Shiny. Any places we can think of to do some profiling comparisons? |
FYI that final release is expected this week: reduxjs/react-redux#473 (comment) |
59529b5
to
638e62e
Compare
Updated to the final release, rebased, and squashed. I'd say this is ready for review. |
This works well in my testing. Were there instructions for checking regressions on the theme component changes? I'm excited for this release, but wonder if we should sit on it for a few days in case there are bugs to be shaken out in a patch version. Their issues list is pretty quiet so far, so maybe a smooth release. |
Not really, sorry -- it's kind of buried in the comment this PR removes. I've added instructions to the PR desc.
Sounds good to me |
Branch looks pretty good so far. 👍 I wasn't able to find any obvious regressions. Let's wait for a few more folks to 👀 |
IE and Edge look good here |
👍 5.0.1 also works well for me. Let's 🚢 tomorrow morning if no one finds any blockers. |
2d160c3
to
410c477
Compare
5.0.0 has finally been released. From the ChangeLog:
To test:
cc @aduth @gwwar @blowery @ehg @mtias