Skip to content

Framework: Upgrade to react-redux v5 #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Framework: Upgrade to react-redux v5 #9707

merged 2 commits into from
Dec 15, 2016

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Nov 29, 2016

5.0.0 has finally been released. From the ChangeLog:

  • Backwards compatible API
  • Major internal changes
  • Significant performance improvements in common usage patterns

Version 5.0 maintains API compatibility with v4.x but due to major internal changes and potential behavior differences across nearly all API surfaces, semver dictates a major version bump. [...] Store state change notifications sent to components are now guaranteed to occur top-down, so if your code may behave differently if it relied on notifications happening out of order.

To test:

  • Verify that Calypso still works as before (obviously 😉 )
  • For the theme sheet specific change:
    • Navigate to a theme sheet on a page of yours (the theme shouldn't be currently active on that page), i.e. http://calypso.localhost:3000/theme//<yoursite.wordpress.com>.
    • Click the activate button
    • Watch a modal show up, with a loading spinner first, and a "Thank you for choosing..." message afterwards.
    • Verify that the "Activate" button's label has changed to "Customize"

cc @aduth @gwwar @blowery @ehg @mtias

@matticbot
Copy link
Contributor

@gwwar
Copy link
Contributor

gwwar commented Nov 30, 2016

Shiny. Any places we can think of to do some profiling comparisons?

@aduth
Copy link
Member

aduth commented Nov 30, 2016

FYI that final release is expected this week: reduxjs/react-redux#473 (comment)

@ockham ockham force-pushed the upgrade/react-redux-5 branch from 59529b5 to 638e62e Compare December 14, 2016 14:43
@ockham
Copy link
Contributor Author

ockham commented Dec 14, 2016

Updated to the final release, rebased, and squashed. I'd say this is ready for review.

@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 14, 2016
@aduth
Copy link
Member

aduth commented Dec 14, 2016

This works well in my testing. Were there instructions for checking regressions on the theme component changes?

I'm excited for this release, but wonder if we should sit on it for a few days in case there are bugs to be shaken out in a patch version. Their issues list is pretty quiet so far, so maybe a smooth release.

@ockham
Copy link
Contributor Author

ockham commented Dec 14, 2016

This works well in my testing. Were there instructions for checking regressions on the theme component changes?

Not really, sorry -- it's kind of buried in the comment this PR removes. I've added instructions to the PR desc.

I'm excited for this release, but wonder if we should sit on it for a few days in case there are bugs to be shaken out in a patch version. Their issues list is pretty quiet so far, so maybe a smooth release.

Sounds good to me

@gwwar
Copy link
Contributor

gwwar commented Dec 14, 2016

Branch looks pretty good so far. 👍 I wasn't able to find any obvious regressions. Let's wait for a few more folks to 👀

@withinboredom
Copy link
Contributor

IE and Edge look good here

@gwwar
Copy link
Contributor

gwwar commented Dec 15, 2016

👍 5.0.1 also works well for me. Let's 🚢 tomorrow morning if no one finds any blockers.

@ockham ockham force-pushed the upgrade/react-redux-5 branch from 2d160c3 to 410c477 Compare December 15, 2016 13:46
@ockham ockham merged commit be40d3b into master Dec 15, 2016
@ockham ockham deleted the upgrade/react-redux-5 branch December 15, 2016 14:32
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants