Fix MeasureCore when there's a size constraint and there's a negative…#18462
Merged
Conversation
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
MrJul
approved these changes
May 31, 2025
Member
There was a problem hiding this comment.
Thanks! It didn't make sense that clamping to the maximum values was done before adding margins, but clamping to the minimum ones (0) was done after.
However, I'm a bit wary of unexpected changes that might not be caught by existing unit tests. MeasureCore is pretty critical! As such, this change is unlikely to be backported to 11.3.
BrycensRanch
pushed a commit
to BrycensRanch/FreeBSD-Avalonia
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… margin.
What does the pull request do?
Fixes size of layoutable when there's a size constraint and negative margin.
What is the current behavior?
The layoutables desired size becomes smaller than expected.
Fixed issues
Fixes #18124