Skip to content

Run Avalonia.LeakTests on CI#19720

Merged
MrJul merged 3 commits into
AvaloniaUI:masterfrom
pos777:leak_tests
Sep 30, 2025
Merged

Run Avalonia.LeakTests on CI#19720
MrJul merged 3 commits into
AvaloniaUI:masterfrom
pos777:leak_tests

Conversation

@pos777

@pos777 pos777 commented Sep 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does the pull request do?

Run Avalonia.LeakTests via DotMemoryUnit on CI

What is the current behavior?

Avalonia.LeakTests always succeeds because DotMemoryUnit is not used

What is the updated/expected behavior with this PR?

Avalonia.LeakTests signals a memory leak

@pos777 pos777 changed the title Check Avalonia.LeakTests Run Avalonia.LeakTests on CI Sep 27, 2025
@pos777

pos777 commented Sep 27, 2025

Copy link
Copy Markdown
Contributor Author

It looks like the tests stopped running on CI after commit c3da4df. Some tests are currently failing. I'm not sure whether to ignore them or handle it differently. What do you think?

@cla-avalonia

cla-avalonia commented Sep 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • All contributors have signed the CLA.

@pos777 pos777 marked this pull request as ready for review September 27, 2025 11:04
@pos777

pos777 commented Sep 27, 2025

Copy link
Copy Markdown
Contributor Author

@cla-avalonia agree

@avaloniaui-bot

avaloniaui-bot commented Sep 28, 2025

Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0059043-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot

avaloniaui-bot commented Sep 29, 2025

Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0059059-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@pos777

pos777 commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

Some tests are currently failing

Fixed

CC @maxkatz6

@MrJul MrJul added enhancement backport-candidate-11.3.x Consider this PR for backporting to 11.3 branch labels Sep 30, 2025
MrJul
MrJul approved these changes Sep 30, 2025
View reviewed changes

@MrJul MrJul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the reflection usage but it's only in our build script so it should be fine. It's better than copying all the logic from Nuke.

LGTM, thank you!

@MrJul MrJul added the area-infrastructure Issues related to CI/tooling infrastructur label Sep 30, 2025
@MrJul MrJul added this pull request to the merge queue Sep 30, 2025
Merged via the queue into AvaloniaUI:master with commit 9bf7abc Sep 30, 2025
12 checks passed
@MrJul MrJul removed the backport-candidate-11.3.x Consider this PR for backporting to 11.3 branch label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrJul MrJul MrJul approved these changes

Assignees

No one assigned

Labels

area-infrastructure Issues related to CI/tooling infrastructur enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pos777 @cla-avalonia @avaloniaui-bot @MrJul