Touch Improvements to TextBox#20848
Conversation
|
You can test this PR using the following package version. |
344b20e to
c07d2c3
Compare
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
bb3444b to
9823926
Compare
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
1523fc7 to
45b9fe2
Compare
|
You can test this PR using the following package version. |
| if(!e.Handled) | ||
| { | ||
| // Gesture may cause an overscroll so we mark the event as handled if it did. | ||
| e.Handled = canXScroll || canYScroll; |
There was a problem hiding this comment.
I'm not sure I understand the logic here, won't that prevent scroll chaining in this case?
There was a problem hiding this comment.
Confirmed while testing, scroll chaining does not work correctly anymore.
|
There's a regression when a selection is active with the context menu open. Previously, double-tapping another word would select it in this case. Now, you need 3 taps instead (one to close the popup, then two for the normal double-tap selection to activate). Please add a test for this once fixed. |
|
I've tested this with a touch screen, and overall, the changes are quite good :) We need more unit tests overall for this. This is not the easiest area to test, but we should be able to validate most of the behaviors added by this PR. They are too easy to break with future changes otherwise. |
…enu show behavior for selection handles
45b9fe2 to
2c81338
Compare
|
You can test this PR using the following package version. |
c2b5d46 to
838793d
Compare
|
You can test this PR using the following package version. |
838793d to
b225d0c
Compare
|
You can test this PR using the following package version. |
|
@MrJul Added tests |
|
You can test this PR using the following package version. |
What does the pull request do?
This PR adds a lot of improvements for touch controls for textbox. Pointer handling for Touch input has been reworked to feel more natural for touch based devices. New behavior closely matches Android's default touch behavior for text inputs.
The following changes and improvements have been made;
PathIconreplaced withImageWhat is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
TextSelectionHandlecontrol theme is updated.Obsoletions / Deprecations
Fixed issues