Rename AppBar controls#21041
Merged
Merged
Conversation
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR rename the newly introduced CommandBar companion control API before 12.0 final.
It renames the public
AppBarButton,AppBarToggleButton, andAppBarSeparatortypes to:CommandBarButtonCommandBarToggleButtonCommandBarSeparatorIt also updates the related CommandBar logic, themes, tests, and ControlCatalog samples to use the new names consistently.
In addition, it addresses
CommandBarSeparatorAPI shape by making it derive fromSeparator.Related issues:
What is the current behavior?
The
CommandBarcontrol uses child controls that are still publicly namedAppBar*, which is inconsistent and confusing.Also,
CommandBarSeparatorcurrently derives directly fromTemplatedControlinstead ofSeparator, even though it conceptually represents a separator.What is the updated/expected behavior with this PR?
The public API is now aligned with the
CommandBarnaming:CommandBarButtonCommandBarToggleButtonCommandBarSeparatorCommandBarSeparatornow derives fromSeparator.How was the solution implemented (if it's not obvious)?
This is a direct rename, without obsolete compatibility wrappers, based on the discussion in #21014.
Implementation details:
AppBar*toCommandBar*CommandBarinternals to use the renamed typesCommandBarSeparatorto inherit fromSeparatorChecklist
Breaking changes
This PR contains source-breaking API changes:
AppBarButtonwas renamed toCommandBarButtonAppBarToggleButtonwas renamed toCommandBarToggleButtonAppBarSeparatorwas renamed toCommandBarSeparatorObsoletions / Deprecations
None.
Fixed issues
Fixes #21014
Fixes #21015