Add back Design.SetPreviewWith(AvaloniaObject, Control) overload#21184
Merged
maxkatz6 merged 2 commits intoApr 19, 2026
Conversation
MrJul
added
bug
area-previewer
backport-candidate-12.0.x
|
You can test this PR using the following package version. |
3 tasks
maxkatz6
approved these changes
Apr 19, 2026
MrJul
added a commit
to MrJul/Avalonia
that referenced
this pull request
Apr 28, 2026
…loniaUI#21184) * Add back Design.SetPreviewWith(AvaloniaObject, Control) overload * Remove dead code
MrJul
added
backported-12.0.x
and removed
backport-candidate-12.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adds back the
Design.SetPreviewWith(AvaloniaObject, Control?)overload that was removed in Avalonia 12, to avoid unexpected exceptions in the previewer.Contrary to #21147, this PR ignores the preview for types deriving from
Control, matching what happened in Avalonia 11. Otherwise, stack overflow exceptions occur if the control is previewed with itself.<Template>should be used instead. The original goal of this PR was to display an "error" preview in this case, telling the user to prefer<Template>. However, we currently have a real overload issue with the XAML compiler, preventing the template overload from being chosen.Since the template overloads are new and mostly unused, for now, let's revert to the Avalonia 11 behavior.
Proper overload support will be added in another PR.Edit: unlikely to occur, this is invalid according to the XAML spec.