Fix safe area calcs for navigation page#21221
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes NavigationPage safe-area handling so the navigation bar height accounts for the top safe-area inset (preventing the safe-area padding from consuming most of the nav bar’s usable header space), addressing #21220.
Changes:
- Adjusts safe-area propagation so
CurrentPage.SafeAreaPaddingis computed using a modified safe-area input depending on nav bar visibility. - Updates
EffectiveBarHeightto includeSafeAreaPadding.Top. - Recomputes effective bar height during safe-area updates.
MrJul
added
bug
backport-candidate-12.0.x
|
You can test this PR using the following package version. |
MrJul
pushed a commit
to MrJul/Avalonia
that referenced
this pull request
Apr 28, 2026
* fix safe area calcs for navigation page * update nav bar effective height on safe area change * reset nav bar height if visibility changes * add tests
MrJul
added
backported-12.0.x
and removed
backport-candidate-12.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes NavigationPage safe area calculations. Safe area padding now considers the nav bar height.
What is the current behavior?
NavBar height doesn't consider the safe area, so when it's set, the extra padding occupies most of the NavBar height, leaving little room for the header.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #21220