Skip to content

Fixed popup positioning anchor rect bug with drawn window decorations#21383

Merged
kekekeks merged 2 commits into
masterfrom
feature/wd/popup-positioning-anchor-rect-fix
May 18, 2026
Merged

Fixed popup positioning anchor rect bug with drawn window decorations#21383
kekekeks merged 2 commits into
masterfrom
feature/wd/popup-positioning-anchor-rect-fix

Conversation

@kekekeks

Copy link
Copy Markdown
Member

Popup's anchor rect needs to be computed against the true root visual and not against toplevel that could be offset by drawn decorations

@kekekeks kekekeks added bug os-windows area-wayland backport-candidate-12.0.x Consider this PR for backporting to 12.0 branch labels May 18, 2026

@MrJul MrJul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test.

@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.1.999-cibuild0065475-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.1.999-cibuild0065517-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks kekekeks enabled auto-merge May 18, 2026 14:35
@kekekeks kekekeks added this pull request to the merge queue May 18, 2026
Merged via the queue into master with commit fc5e939 May 18, 2026
11 checks passed
@kekekeks kekekeks deleted the feature/wd/popup-positioning-anchor-rect-fix branch May 18, 2026 17:00
MrJul pushed a commit to MrJul/Avalonia that referenced this pull request May 28, 2026
…AvaloniaUI#21383)

* Fixed popup positioning anchor rect bug with drawn window decorations

* added test
@MrJul MrJul added backported-12.0.x and removed backport-candidate-12.0.x Consider this PR for backporting to 12.0 branch labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants