Fix: correct usage of PointToScreen for Android TalkBack#21402
Merged
Conversation
|
You can test this PR using the following package version. |
MrJul
added
os-android
area-accessibility
backport-candidate-12.0.x
MrJul
pushed a commit
to MrJul/Avalonia
that referenced
this pull request
May 28, 2026
MrJul
added
backported-12.0.x
and removed
backport-candidate-12.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR patches the Android TalkBack plugin for Avalonia (previously implemented in #17704) to update its usage of the
Visual.PointToScreenextension method such that correct screen coordinates are reported to the TalkBack API.What is the current behavior?
The current behavior is broken due to updates provided in #20624 which switch the preferred method for gathering screen-space coordinates from
TopLevel.PointToScreentoIInputRoot.RootElement.PointToScreen. Now, Android TalkBack uses the correct internal API per this change.What is the updated/expected behavior with this PR?
Before this PR, Avalonia 12 on Android devices would show strangely offset outlines while using Android TalkBack. Now, the correct bounds are reported to the OS and the outlines show as expected.
Checklist