Repository navigation
Use a TextBlock's AutomationProperties.Name as its automation name - #22605
Open
hazeliscoding wants to merge 2 commits into
Open
hazeliscoding wants to merge 2 commits into
hazeliscoding wants to merge 2 commits into
Conversation
AutomationProperties.Name set on a TextBlock is ignored, and every Text change raises a name change even when an explicit name is set.
TextBlockAutomationPeer now reads the explicit name first, like the other peers, and raises a name change for a Text change only when the text is the name.
MrJul
added
enhancement
area-accessibility
backport-candidate-12.1.x
NuGet packagesThe packages for this pull request have been published (workflow run):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
TextBlockAutomationPeerused a TextBlock's text as its automation name even whenAutomationProperties.Namewas set, and raised a name change on everyTextchange. It now readsAutomationProperties.Nameand thenLabeledByfirst, likeContentControlAutomationPeerand the page peers, and falls back to the text. ATextchange raises a name change only when the text is the name.SelectableTextBlockuses the same peer, so it's fixed too.What is the current behavior?
AutomationProperties.Nameon aTextBlockhas no effect. A TextBlock withAutomationProperties.LiveSettingis announced on every text change, even when an explicit name was set to stop that.How was the solution implemented (if it's not obvious)?
The first commit adds the tests. Two fail without the fix, and two check that the text is still the name, and still raises name changes, when no explicit name is set.
Fixed issues
Fixes #22584