Skip to content

WIP: Use ItemsRepeater as base for ItemsPresenter - #3388

Closed
grokys wants to merge 9 commits into
masterfrom
refactor/itemsrepeater-as-itemspresenter
Closed

grokys wants to merge 9 commits into
masterfrom
refactor/itemsrepeater-as-itemspresenter

Conversation

@grokys

@grokys grokys commented Dec 23, 2019

Copy link
Copy Markdown
Member

What does the pull request do?

Work-in-progress in getting ItemsRepeater to be the base for ItemsPresenter.

microsoft/microsoft-ui-xaml#1425 describes a bug which causes scrolling to break with `ItemsRepeater`. This is a temporary fix that seems to work around it - not sure if it's the correct fix so when the WinUI issue is fixed, undo this change and port the change from there if it's different.
Move `ContainerFromIndex` and `IndexFromContainer` from `SelectingItemsControl` to `ItemsControl` and make them public.
@grokys

grokys commented Jul 8, 2020

Copy link
Copy Markdown
Member Author

Closing this as it's out-of-date, will open a new PR to implement this soon.

@grokys grokys closed this Jul 8, 2020
@robloo robloo mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant