App Crash due to VisualLinesInvalidException

[IvanJosipovic]

I got this crash in my app, it doesn't seem to be related to any of my code.

Any suggestions on how to resolve this?

Avalonia.AvaloniaEdit version="11.3.0"
Avalonia version="11.3.1"

AvaloniaEdit.Rendering.VisualLinesInvalidException: Exception of type 'AvaloniaEdit.Rendering.VisualLinesInvalidException' was thrown.
   at AvaloniaEdit.Rendering.TextView.get_VisualLines()
   at AvaloniaEdit.Rendering.BackgroundGeometryBuilder.GetRectsForSegmentImpl(TextView textView, ISegment segment, Boolean extendToFullWidthAtLineEnd)+MoveNext()
   at AvaloniaEdit.Rendering.BackgroundGeometryBuilder.AddSegment(TextView textView, ISegment segment)
   at AvaloniaEdit.Editing.SelectionLayer.Render(DrawingContext drawingContext)
   at Avalonia.Rendering.Composition.CompositingRenderer.UpdateCore()
   at Avalonia.Rendering.Composition.CompositingRenderer.Update()
   at Avalonia.Rendering.Composition.Compositor.CommitCore()
   at Avalonia.Rendering.Composition.Compositor.Commit()
   at Avalonia.Media.MediaContext.CommitCompositorsWithThrottling()
   at Avalonia.Media.MediaContext.CompositionBatchFinished(Compositor compositor, CompositionBatch batch)
   at Avalonia.Threading.DispatcherOperation.InvokeCore()
   at Avalonia.Threading.DispatcherOperation.Execute()
   at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation job)
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean fromExplicitBackgroundProcessingCallback)
   at Avalonia.Threading.Dispatcher.Signaled()
   at Avalonia.Win32.Win32Platform.WndProc(IntPtr hWnd, UInt32 msg, IntPtr wParam, IntPtr lParam)
   at Avalonia.Win32.Interop.UnmanagedMethods.DispatchMessage(MSG& lpmsg)
   at Avalonia.Win32.Win32DispatcherImpl.RunLoop(CancellationToken cancellationToken)
   at Avalonia.Threading.DispatcherFrame.Run(IControlledDispatcherImpl impl)
   at Avalonia.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken)
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.StartCore(String[] args)
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, Action`1 lifetimeBuilder)
   at KubeUI.Desktop.Program.Main(String[] args)

[kkmserver]

Same thing.

Playback:

1. Open a text document with several pages of text,
2. Press Ctrl-F, type the text
3. Search down several times.

AvaloniaUI 11.3.1 is installed

[Gillibald]

Please create a sample that can be run as is and reproduces the issue. Otherwise, no one can investigate this. You can also run AvaloniaEdit from the source and debug it yourself.

[kkmserver]

AvaloniaEdit-error.zip

Playback:

1. Compile, run,
2. Focus on the text editing window (mouse into the text)
3. Press Ctrl-F, type "CSharp"
4. Press the search button down from 5 to 50 times - an exception is guaranteed to pop up

PS: I changed almost nothing in your demo - I only switched to net.9 and AvaloniaUI 11.3.1 + increased the text size in the example

[NotroDev]

Hey, I also encountered this issue. I'm 90% sure it's only happening when Avalonia 11.3.1 or 11.3.2 is installed - it wasn't happening on 11.3.0.

[IvanJosipovic]

I was also able to reproduce this issue in my app by doing a search for character 'a' and pressing F3 a bunch of times.

[justinshannon]

I'm also experiencing this crash in one of my applications, and it appears to be related to this commit: 77d9a43

Commenting out the line _visibleVisualLines = null in DisposeVisualLine stops the crash for me. However, I'm not sure if this is a proper fix or just a hacky workaround.

[danipen]

@emmauss

[YoshihiroIto]

I am using AvaloniaEdit. Thank you for your great work.
A similar exception has also been reported in my application.

[alexandrehtrb]

Same problem here. I tested many times and I don't know how to reproduce this bug. It wasn't happening with AvaloniaEdit 11.0.5.

[love-linger]

I am also using AvaloniaEdit in my project. I found that when selecting a very long line of text (with a horizontal scroll bar) up to the boundary, it is easy to trigger AvaloniaEdit.Rendering.VisualLinesInvalidException

• Screenshot

crash.mp4

• Crash log

AvaloniaEdit.Rendering.VisualLinesInvalidException: Exception of type 'AvaloniaEdit.Rendering.VisualLinesInvalidException' was thrown.
   at AvaloniaEdit.Rendering.TextView.get_VisualLines() + 0x36
   at AvaloniaEdit.Rendering.BackgroundGeometryBuilder.<GetRectsForSegmentImpl>d__21.MoveNext() + 0x270
   at AvaloniaEdit.Rendering.BackgroundGeometryBuilder.AddSegment(TextView, ISegment) + 0x70
   at AvaloniaEdit.Editing.SelectionLayer.Render(DrawingContext) + 0x1ac
   at Avalonia.Rendering.Composition.CompositingRenderer.UpdateCore() + 0x97
   at Avalonia.Rendering.Composition.CompositingRenderer.Update() + 0x7b
   at Avalonia.Rendering.Composition.Compositor.CommitCore() + 0x11b
   at Avalonia.Rendering.Composition.Compositor.Commit() + 0x15
   at Avalonia.Media.MediaContext.CommitCompositor(Compositor) + 0x4e
   at Avalonia.Media.MediaContext.CommitCompositorsWithThrottling() + 0xf5
   at Avalonia.Media.MediaContext.CompositionBatchFinished(Compositor, CompositionBatch) + 0x78
   at Avalonia.Threading.DispatcherOperation.InvokeCore() + 0x1bc
   at Avalonia.Threading.DispatcherOperation.Execute() + 0x4c
   at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation) + 0x73
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean) + 0x3d
   at Avalonia.Threading.Dispatcher.Signaled() + 0x41
   at Avalonia.Win32.Win32Platform.WndProc(IntPtr hWnd, UInt32 msg, IntPtr wParam, IntPtr lParam) + 0x58
   at SourceGit!<BaseAddress>+0x12cb95a

[Sputnik24]

Do we have an update here?

[Gillibald]

I'm also experiencing this crash in one of my applications, and it appears to be related to this commit: 77d9a43

Commenting out the line _visibleVisualLines = null in DisposeVisualLine stops the crash for me. However, I'm not sure if this is a proper fix or just a hacky workaround.

This change matches the original version: https://github.com/icsharpcode/AvalonEdit/blob/master/ICSharpCode.AvalonEdit/Rendering/TextView.cs#L719

So there might be more differences that need to be reverted.