ci: Refactor pipeline and sample data uploading workflows and updated client secrets to oidc#2120
Open
Vamshi-Microsoft wants to merge 28 commits intoAzure-Samples:mainfrom
Open
ci: Refactor pipeline and sample data uploading workflows and updated client secrets to oidc#2120Vamshi-Microsoft wants to merge 28 commits intoAzure-Samples:mainfrom
Vamshi-Microsoft wants to merge 28 commits intoAzure-Samples:mainfrom
Conversation
- Created `import_sample_data_postgresql.sh` to facilitate importing data into the PostgreSQL vector_store table. - The script validates input parameters, checks Azure CLI login status, and discovers PostgreSQL Flexible Server in the specified resource group. - It handles network access configuration, adds necessary firewall rules, and installs required Azure CLI extensions. - The script also adds the current user as a PostgreSQL Entra ID administrator and installs Python dependencies before importing data from a CSV file. - Includes error handling and cleanup procedures to ensure proper execution and rollback of changes.
…for sample data in CosmosDB and PostgreSQL with WAF support
…greSQL and CosmosDB workflows
- Updated the admin page title validation to check for substring match instead of exact match. - Changed the Hebrew PDF filename in test cases to remove the space for consistency.
…count instead of keeping them within repo
ci: Added tag support for RG and enhanced sample data importing steps
…eference link checks
…egion validation and error handling
…ogging for better traceability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates several GitHub Actions workflows to improve security, streamline Azure authentication, and simplify configuration. The main focus is on migrating from client secret–based authentication to OIDC (OpenID Connect) federated identity for Azure logins, enhancing secrets management, and making input handling more robust and flexible.
Key improvements include:
Azure Authentication & Security
Migrated all workflows (
ci.yml,build-docker.yml,import-sample-data-postgresql.yml) to use OIDC-based Azure authentication via theazure/login@v2action, replacing client secret usage with federated tokens and removing related secrets and environment variables. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Updated workflow permissions to explicitly grant
id-token: writefor OIDC and limited other permissions tocontents: readandpackages: writewhere needed. [1] [2] [3] [4]Workflow Input Handling & Validation
Made
resource_group_nameoptional indeploy-v2.yml, with improved validation and messaging for auto-generation if not provided. Updated default runner OS logic and input passing to orchestrator workflow. [1] [2] [3] [4]Removed the need to provide or validate the PostgreSQL host name as a workflow input in
import-sample-data-postgresql.yml, simplifying the input requirements. [1] [2]Docker Build & Registry
Sample Data Import Automation
import-sample-data-postgresql.ymlworkflow.Miscellaneous
RESOURCE_TOKENfromdeploy-orchestrator.yml.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information