Migrate v3 programming model to v4 related with PR - #174 #231

glaucia86 · 2023-07-04T19:24:37Z

Hi, folks.

This issue is related with #174.

cc: @manekinekko @anfibiacreativa

…t.ts

… winston-transport)

… config - WIP

glaucia86 · 2023-09-12T15:18:20Z

@glaucia86 did you commit these changes to this PR? I don't see the new commit 😅

@manekinekko now is finally done!

infra/core/database/postgresql/flexibleserver.bicep

infra/main.bicep

packages/portal/package.json

scripts/database/restore.sh

manekinekko · 2023-09-13T07:36:08Z

@glaucia86 can you also add a readme.md file under packages/api-v4/ explaning how to start the new API? (similarily to packages/api/README.md). Some steps are necessary for the new API to execute, for instance renaming local.settings.sample.json to local.settings.json, etc...

fix: following up code review

fix: following up the code review

…glaucia86/contoso-real-estate into feat/migrate-v3-to-v4-functions

packages/api-v4/README.md

infra/core/database/postgresql/flexibleserver.bicep

glaucia86 · 2023-09-13T23:29:49Z

@manekinekko I made the changes as asked. Thanks a lot :)

…for release v4

… into feat/migrate-v3-to-v4-functions

gabrieljoelc · 2023-09-29T17:42:46Z

great PR and related blog post!

I have a question and one feedback:

Question: how did you generate the openapi.yml file?
Feedback: I wonder if it would have been easier to understand the v3 to v4 differences if the formatting changes were included in a separate PR

gabrieljoelc · 2023-09-29T17:50:15Z

packages/api-v4/src/index.ts

+import { postCheckout } from "./functions/checkout";
+
+//#region User Function
+app.get("get-users", {


I love this index.ts file aggregating the bindings from the functions. It loosens the coupling between the endpoints and the Azure Function infrastructure a bit.

It also makes it easier to see the possibility of generating functions or bindings based on convention. I've always wished we could Railsify the creation of Azure Functions.

glaucia86 · 2023-10-04T14:08:14Z

Question: how did you generate the openapi.yml file?

Feedback: I wonder if it would have been easier to understand the v3 to v4 differences if the formatting changes were included in a separate PR

Hi, @gabrieljoelc. How are you?

Unfortunately, it was a feature that should have been delivered as soon as possible due to the recent release. However, if you'd like to know more details about how a particular function was implemented, you can check out this blog I wrote with a step-by-step guide: HERE

About the openapi.yaml file, it was created by @manekinekko, and he would be better equipped to provide a response than I am.

@ApplicationInsights

Azure-Samples#231) * feat(api-v4): initial commit with v4 programming model httpTriggerTest.ts * fix(api-v4): removing unecessary console.log * chore(api-v4): install new dependecies and devdependecies * chore(api-v4): development of the 'User' schema * refactor(api-v4): create 'User' interface * fix(api-v4): fixing import file path * fix(api-v4): fixing import file path * chore(api-v4): initialize the getUser.ts development * fix(api-v4): fix typo * chore(api-v4): include schema templates * chore(api-v4): modified 'tsconfig.json' file config * chore(api-v4): install new packages (applicationinsights, winston and winston-transport) * fix(api-v4): remove unecessary comments * chore(api-v4): dcreate interfaces in 'appConfig.ts' * chore(api-v4): development of mongoose configuration - WIP * chore(api-v4): development of the 'observability.ts'services - WIP * chore(api-v4): development of the Winston Transports and App Insights config - WIP * fix(api-v4): remove unecessary file * refactor(api-v4): using type inferece to refactor the file * chore(api-v4): changing the typescript version * chore(api-v4): development of the 'applicationInsightsTransports' * fix(api-v4): typo * fix(api-v4): renaming the function from 'getUsers' to 'users' * chore(api-v4): migrating 'get-users'(v3) to 'users' (v4) functions * chore(api-v4): migrating 'get-user-by-id'(v3) to 'user' (v4) functions * chore(api-v4): development of the 'observability' file * chore(api-v4): finish development of the 'mongoose.ts' file * chore(api-v4): install packages: pg,azure-key-vault, aad * chore(api-v4): development of the postgres database configuration * chore(api-v4): development of the 'index.ts' file from 'config' folder * chore(api-v4): including the '.env_example' and 'openapi.yaml' files * chore(api-v4): development of the 'payment.schema.ts' file * chore(api-v4): development of the 'payment.ts' file * fix(api-v4): modify method name * fix(api-v4): style typo * chore(api-v4): migration from v3 to v4 from: 'get-payment-by-id' function * chore(api-v4): add 'toUpperCase for get secret names * chore(api-v4): rename the function's name * chore(api-v4): create new files for refactor * chore(api-v4): development of middleware for api-v4 * refactor(api-v4): refactoring the new api-v4 * fix(api-v4): some important changes * chore(api-v4): include TODO for 'initializeDatabaseConfiguration' method * chore(api-v4): development of the get-payments function * chore(api-v4): development of the get-payments function * chore(api-v4): include 'local.settings.sample.json' and removed 'NOTES.md' file from .gitignore * chore(api-v4): development of the 'reservation.schema.ts' file * refactor(api-v4): applied refactor in the 'updatePaymentStatus' method * chore(api-v4): development of the 'reservation.ts' file * chore(api-v4): development of the 'reservation-request.ts' file * chore(api-v4): development of the models: 'favorite' and 'listing' * chore(api-v4): include ObjectId from mongoose in the 'getListingById' method * chore(api-v4): development of the 'get-reservation-by-id' function from v3 to v4 * fix(api-v4): fix typo * chore(api-v4): development of the 'get-reservation' function from v3 to v4 * fix(api-v4): fix typo * chore(api-v4): include a typescript flag in the 'start' script cmd * chore(api-v4): development of the 'get-favorites' function from v3 to v4 * chore(api-v4): changing the tsconfig.json according from the 'api' * chore(api-v4): change the 'routePrefix' * chore(api-v4): update 'local.settings.sample.json' file * chore(api-v4): removing header * chore(api-v4): development of the 'get-listing-by-id' function from v3 to v4 * chore(api-v4): development of the 'get-listing' function from v3 to v4 * chore(api-v4): development of the 'openapi' function from v3 to v4 * chore(api-v4): returning with interfaces * chore(api-v4): development of the 'post-user' function from v3 to v4 * chore(api-v4): development of the 'post-payment' function from v3 to v4 * refactor(api-v4): create 'isValidPayment' to refactor 'postPayment' function * chore(api-v4): development of the 'post-favorite' function from v3 to v4 * fix(api-v4): return with interfaces in reservation * chore(api-v4): development of the 'checkout' function from v3 to v4 * chore(api-v4): include the same pattern for error messages * chore(api-v4): development of the 'delete-favorite' function from v3 to v4 * refactor(api-v4): return with interfaces - Favorite * chore(api-v4): development of the 'patch-reservation-by-id' function from v3 to v4 * fix(api-v4): returning with interfaces 'Payment' * chore(api-v4): including a pattern for error messages * chore(api-v4): removing unecessary file and function * chore(api-v4): remove header and unecessary file * fix(api-v4): change from 'console' to 'context' * refactor(api-v4): include a type 'DeleteFavoriteRequestBody' * refactor(api-v4): include try-catch block * chore(api-v4): including packages according to the 'api' * fix(api-v4): rename the '.env.template' file * fix(api-v4): rename the file * fix(api-v4): changes in the '.gitignore' file * chore(api-v4): added some new config to be ignored in the application * fix(api-v4): remove unecessary ignored config * fix(api-v4): change 'routePrefix' * fix(api-v4): update '@azure/functions' package * fix(api-v4): removed the conversion * chore(api-v4): add comment * chore: include the 'api-v4' in the main package.json file * chore: update the 'package-lock.json' file * chore: important update in the 'applicationinsights' package * chore: include double quotes * chore: include the application insights transport importation * chore: update the 'local.settings.json' file * feat(api-v4): initial commit with v4 programming model httpTriggerTest.ts * fix(api-v4): removing unecessary console.log * fix(api-v4): removing unecessary console.log * chore(api-v4): install new dependecies and devdependecies * chore(api-v4): development of the 'User' schema * refactor(api-v4): create 'User' interface * fix(api-v4): fixing import file path * fix(api-v4): fixing import file path * chore(api-v4): initialize the getUser.ts development * fix(api-v4): fix typo * chore(api-v4): include schema templates * chore(api-v4): modified 'tsconfig.json' file config * chore(api-v4): install new packages (applicationinsights, winston and winston-transport) * fix(api-v4): remove unecessary comments * chore(api-v4): dcreate interfaces in 'appConfig.ts' * chore(api-v4): development of mongoose configuration - WIP * chore(api-v4): development of the 'observability.ts'services - WIP * chore(api-v4): development of the Winston Transports and App Insights config - WIP * fix(api-v4): remove unecessary file * refactor(api-v4): using type inferece to refactor the file * chore(api-v4): changing the typescript version * chore(api-v4): development of the 'applicationInsightsTransports' * fix(api-v4): typo * fix(api-v4): renaming the function from 'getUsers' to 'users' * chore(api-v4): migrating 'get-users'(v3) to 'users' (v4) functions * chore(api-v4): migrating 'get-user-by-id'(v3) to 'user' (v4) functions * chore(api-v4): development of the 'observability' file * chore(api-v4): finish development of the 'mongoose.ts' file * chore(api-v4): install packages: pg,azure-key-vault, aad * chore(api-v4): development of the postgres database configuration * chore(api-v4): development of the 'index.ts' file from 'config' folder * chore(api-v4): including the '.env_example' and 'openapi.yaml' files * chore(api-v4): development of the 'payment.schema.ts' file * chore(api-v4): development of the 'payment.ts' file * fix(api-v4): modify method name * fix(api-v4): style typo * chore(api-v4): migration from v3 to v4 from: 'get-payment-by-id' function * chore(api-v4): add 'toUpperCase for get secret names * chore(api-v4): rename the function's name * chore(api-v4): create new files for refactor * chore(api-v4): development of middleware for api-v4 * refactor(api-v4): refactoring the new api-v4 * fix(api-v4): some important changes * chore(api-v4): include TODO for 'initializeDatabaseConfiguration' method * chore(api-v4): development of the get-payments function * chore(api-v4): development of the get-payments function * chore(api-v4): include 'local.settings.sample.json' and removed 'NOTES.md' file from .gitignore * chore(api-v4): development of the 'reservation.schema.ts' file * refactor(api-v4): applied refactor in the 'updatePaymentStatus' method * chore(api-v4): development of the 'reservation.ts' file * chore(api-v4): development of the 'reservation-request.ts' file * chore(api-v4): development of the models: 'favorite' and 'listing' * chore(api-v4): include ObjectId from mongoose in the 'getListingById' method * chore(api-v4): development of the 'get-reservation-by-id' function from v3 to v4 * fix(api-v4): fix typo * chore(api-v4): development of the 'get-reservation' function from v3 to v4 * fix(api-v4): fix typo * chore(api-v4): include a typescript flag in the 'start' script cmd * chore(api-v4): development of the 'get-favorites' function from v3 to v4 * chore(api-v4): changing the tsconfig.json according from the 'api' * chore(api-v4): change the 'routePrefix' * chore(api-v4): update 'local.settings.sample.json' file * chore(api-v4): removing header * chore(api-v4): development of the 'get-listing-by-id' function from v3 to v4 * chore(api-v4): development of the 'get-listing' function from v3 to v4 * chore(api-v4): development of the 'openapi' function from v3 to v4 * chore(api-v4): returning with interfaces * chore(api-v4): development of the 'post-user' function from v3 to v4 * chore(api-v4): development of the 'post-payment' function from v3 to v4 * refactor(api-v4): create 'isValidPayment' to refactor 'postPayment' function * chore(api-v4): development of the 'post-favorite' function from v3 to v4 * fix(api-v4): return with interfaces in reservation * chore(api-v4): development of the 'checkout' function from v3 to v4 * chore(api-v4): include the same pattern for error messages * chore(api-v4): development of the 'delete-favorite' function from v3 to v4 * refactor(api-v4): return with interfaces - Favorite * chore(api-v4): development of the 'patch-reservation-by-id' function from v3 to v4 * fix(api-v4): returning with interfaces 'Payment' * chore(api-v4): including a pattern for error messages * chore(api-v4): removing unecessary file and function * chore(api-v4): remove header and unecessary file * fix(api-v4): change from 'console' to 'context' * refactor(api-v4): include a type 'DeleteFavoriteRequestBody' * refactor(api-v4): include try-catch block * chore(api-v4): including packages according to the 'api' * fix(api-v4): rename the '.env.template' file * fix(api-v4): rename the file * fix(api-v4): changes in the '.gitignore' file * chore(api-v4): added some new config to be ignored in the application * fix(api-v4): remove unecessary ignored config * fix(api-v4): change 'routePrefix' * fix(api-v4): update '@azure/functions' package * fix(api-v4): removed the conversion * chore(api-v4): add comment * chore: include the 'api-v4' in the main package.json file * chore: update the 'package-lock.json' file * chore: important update in the 'applicationinsights' package * chore: include double quotes * chore: include the application insights transport importation * chore: update the 'local.settings.json' file * chore: include '@apollo/client' package * fix: follow up the code review * chore: install 'apollo/client' * Update flexibleserver.bicep fix: following up code review * Update main.bicep fix: following up the code review * fix: remove unecessary space * fix: following up the code review * docs: include README.md file under api-v4 folder * docs: update the README.md under api-v4 folder * fix: following up the code review * chore: running npm i command * chore: update '@azure/functions' and '@ApplicationInsights' packages for release v4 * chore: execute 'npm run format' command * docs: include the README.md according from the main branch --------- Co-authored-by: Julien Dubois <[email protected]> Co-authored-by: Natalia Venditto <[email protected]>

feat(api-v4): initial commit with v4 programming model httpTriggerTes…

8d57bea

…t.ts

glaucia86 requested review from anfibiacreativa, manekinekko and sinedied as code owners July 4, 2023 19:24

glaucia86 self-assigned this Jul 4, 2023

glaucia86 added the scope: api label Jul 4, 2023

glaucia86 mentioned this pull request Jul 4, 2023

[Chore] Migrate all Node.js functions to the new v4 programming model #174

Closed

glaucia86 added 2 commits July 4, 2023 21:40

fix(api-v4): removing unecessary console.log

e55c5aa

chore(api-v4): install new dependecies and devdependecies

fada6fe

glaucia86 marked this pull request as draft July 4, 2023 21:43

glaucia86 changed the title ~~Migrate v3 programming model to v4 related with #174]~~ Migrate v3 programming model to v4 related with #174 Jul 4, 2023

glaucia86 changed the title ~~Migrate v3 programming model to v4 related with #174~~ Migrate v3 programming model to v4 related with PR - #174 Jul 4, 2023

glaucia86 added 7 commits July 4, 2023 23:36

chore(api-v4): development of the 'User' schema

90d4c16

refactor(api-v4): create 'User' interface

25d6b7c

fix(api-v4): fixing import file path

ee219a8

fix(api-v4): fixing import file path

1526db3

chore(api-v4): initialize the getUser.ts development

8b5957f

fix(api-v4): fix typo

c543f6f

chore(api-v4): include schema templates

59f7d6e

glaucia86 mentioned this pull request Jul 5, 2023

chore: v4 migration boilerplate #214

Closed

glaucia86 added 7 commits July 5, 2023 16:03

chore(api-v4): modified 'tsconfig.json' file config

3f679ca

chore(api-v4): install new packages (applicationinsights, winston and…

049117c

… winston-transport)

fix(api-v4): remove unecessary comments

b0c28fa

chore(api-v4): dcreate interfaces in 'appConfig.ts'

56c7379

chore(api-v4): development of mongoose configuration - WIP

501a42e

chore(api-v4): development of the 'observability.ts'services - WIP

ce31140

chore(api-v4): development of the Winston Transports and App Insights…

6921f1c

… config - WIP

glaucia86 marked this pull request as ready for review July 5, 2023 23:08

glaucia86 marked this pull request as draft July 5, 2023 23:10

fix(api-v4): remove unecessary file

a693fe3

chore: install 'apollo/client'

8c22ffa

Merge branch 'main' into feat/migrate-v3-to-v4-functions

c219b05

manekinekko suggested changes Sep 13, 2023

View reviewed changes

infra/core/database/postgresql/flexibleserver.bicep Show resolved Hide resolved

infra/main.bicep Show resolved Hide resolved

packages/portal/package.json Outdated Show resolved Hide resolved

scripts/database/restore.sh Show resolved Hide resolved

glaucia86 added 6 commits September 13, 2023 06:15

Update flexibleserver.bicep

4cd3292

fix: following up code review

Update main.bicep

c6776cd

fix: following up the code review

fix: remove unecessary space

808c135

fix: following up the code review

b4b2a2b

docs: include README.md file under api-v4 folder

134977a

Merge branch 'feat/migrate-v3-to-v4-functions' of https://github.com/…

fe9b2de

…glaucia86/contoso-real-estate into feat/migrate-v3-to-v4-functions

manekinekko suggested changes Sep 13, 2023

View reviewed changes

glaucia86 added 2 commits September 13, 2023 23:28

docs: update the README.md under api-v4 folder

d726719

fix: following up the code review

526f41f

glaucia86 requested a review from manekinekko September 13, 2023 23:29

glaucia86 added 5 commits September 20, 2023 12:59

chore: running npm i command

da606ff

Merge branch 'Azure-Samples:main' into feat/migrate-v3-to-v4-functions

3e0c43a

chore: update '@azure/functions' and '@ApplicationInsights' packages …

7d58394

…for release v4

chore: execute 'npm run format' command

af17afd

Merge branch 'main' of https://github.com/glaucia86/contoso-real-estate…

6f9ecdc

… into feat/migrate-v3-to-v4-functions

gabrieljoelc reviewed Sep 29, 2023

View reviewed changes

glaucia86 added 2 commits October 1, 2023 03:49

docs: include the README.md according from the main branch

00e25e6

Merge branch 'main' into feat/migrate-v3-to-v4-functions

9de02f3

Merge branch 'main' into feat/migrate-v3-to-v4-functions

ac7720e

anfibiacreativa approved these changes Oct 18, 2023

View reviewed changes

anfibiacreativa merged commit e88a755 into Azure-Samples:main Oct 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate v3 programming model to v4 related with PR - #174 #231

Migrate v3 programming model to v4 related with PR - #174 #231

Uh oh!

glaucia86 commented Jul 4, 2023 •

edited

Loading

Uh oh!

glaucia86 commented Sep 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manekinekko commented Sep 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

glaucia86 commented Sep 13, 2023

Uh oh!

gabrieljoelc commented Sep 29, 2023 •

edited

Loading

Uh oh!

gabrieljoelc Sep 29, 2023

Uh oh!

glaucia86 commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Migrate v3 programming model to v4 related with PR - #174 #231

Migrate v3 programming model to v4 related with PR - #174 #231

Uh oh!

Conversation

glaucia86 commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

glaucia86 commented Sep 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manekinekko commented Sep 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

glaucia86 commented Sep 13, 2023

Uh oh!

gabrieljoelc commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabrieljoelc Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

glaucia86 commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

glaucia86 commented Jul 4, 2023 •

edited

Loading

gabrieljoelc commented Sep 29, 2023 •

edited

Loading