Skip to content

fix: Batch Explorer can't download filename contains "#" #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

wanghoppe
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ac92a74) 67.27% compared to head (4f1d2bc) 67.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
- Coverage   67.27%   67.26%   -0.01%     
==========================================
  Files        1228     1228              
  Lines       33618    33620       +2     
  Branches     6208     6158      -50     
==========================================
  Hits        22615    22615              
- Misses      10856    10858       +2     
  Partials      147      147              
Files Coverage Δ
.../src/app/services/azure-batch/file/file.service.ts 46.09% <0.00%> (-0.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac92a74...4f1d2bc. Read the comment docs.

@wanghoppe wanghoppe enabled auto-merge (squash) December 21, 2023 15:13
@wanghoppe wanghoppe merged commit 140c958 into main Dec 21, 2023
@wanghoppe wanghoppe deleted the hoppe/fix-download branch December 21, 2023 15:24
@cRui861
Copy link
Member

cRui861 commented Jan 9, 2024

Fixes #2877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants