update dependency version #2172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazrael2119
requested review from
sarangan12,
joheredi,
qiaozha and
MaryGao
as code owners
MaryGao
reviewed
Dec 26, 2023
kazrael2119
commented
Dec 27, 2023
| @@ -1001,7 +1001,7 @@ describe("LRO Rest Client", () => { | |||
| assert.equal(result.status, "200"); | |||
| }); | |||
|
|
|||
| it("should handle put200InvalidJson", async () => { | |||
| it.only("should handle put200InvalidJson", async () => { | |||
There was a problem hiding this comment.
repro ci test failure in my local env.
step:
- start a git bash
- run
rush update && rush build cd package/autorest.typescript- run
rushx start-test-server:v2 - start a new git bash again
cd package/autorest.typescript- run
rushx rlc-integration-test:alone - run
rushx stop-test-server
qiaozha
reviewed
Jan 18, 2024
| @@ -109,10 +109,10 @@ | |||
| "node-cmd": "^3.0.0", | |||
| "npm-run-all": "^4.1.5", | |||
| "path-browserify": "^1.0.1", | |||
| "puppeteer": "^3.3.0", | |||
| "puppeteer": "^21.6.0", | |||
There was a problem hiding this comment.
in main, it's "^21.0.0"
|
can we close this as of #2357 ? |
|
close it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2167
update sinon, directory-tree puppeteer versions to fix this issue