Serialization: Fixes default JsonSerializerSettings #3313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
leminh98,
neildsh and
sboshra
as code owners
j82w
reviewed
Jun 28, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosJsonSeriliazerUnitTests.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
requested changes
Jun 28, 2022
j82w
reviewed
Jun 28, 2022
...zure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Batch/BatchSinglePartitionKeyTests.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
Jun 28, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to GHSA-5crp-9r3c-p9vr
Quoting:
To mitigate the issue one either need to update Newtonsoft.Json to 13.0.1 or set MaxDepth parameter in the JsonSerializerSettings.
Mirroring JamesNK/Newtonsoft.Json@b6dc05b#diff-c35f33ecfb40348a47f9e6cee6c162ef4cad59d70fb1216d62180dbe59562aa4
We are setting the MaxDepth to 64.
Because bumping the Newtonsoft.Json dependency from 10.0.2 to 13.0.1 might incur into Newtonsoft breaking changes, we opt for applying the change in the JsonSerializerSettings we create in the SDK.
Closes #3312