Skip to content

Diagnostics: Removes unused properties and reduces size #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ealsur merged 12 commits into from
Nov 2, 2022
Merged

Diagnostics: Removes unused properties and reduces size #3519

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d41354c
Remove starttime and id from diagnostics string
aavasthy Oct 27, 2022
e7610f9
Remove starttime and id from diagnostics string
aavasthy Oct 27, 2022
09b7cad
Update xml files for trace baseline tests
aavasthy Oct 28, 2022
218d52b
Merge branch 'master' into users/aavasthy/ReduceDiagnosticsStringLength
aavasthy Oct 28, 2022
a969bf7
Update xml files for trace baseline tests
aavasthy Oct 28, 2022
f74232d
Merge branch 'users/aavasthy/ReduceDiagnosticsStringLength' of https:…
aavasthy Oct 28, 2022
bfc3d9d
Update xml files for trace baseline tests
aavasthy Oct 28, 2022
a277c8f
Merge branch 'master' into users/aavasthy/ReduceDiagnosticsStringLength
aavasthy Oct 30, 2022
8d02598
Whitespaces update
aavasthy Oct 31, 2022
4423b4d
Changed starttime position based on code review
aavasthy Nov 1, 2022
4eea148
Merge branch 'master' into users/aavasthy/ReduceDiagnosticsStringLength
aavasthy Nov 1, 2022
d6957ff
Merge branch 'master' into users/aavasthy/ReduceDiagnosticsStringLength
ealsur Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,14 @@ public static void WriteTrace(
SummaryDiagnostics summaryDiagnostics = new SummaryDiagnostics(trace);
summaryDiagnostics.WriteSummaryDiagnostics(writer);
}

writer.WriteFieldName("name");
writer.WriteStringValue(trace.Name);

writer.WriteFieldName("id");
writer.WriteStringValue(trace.Id.ToString());

writer.WriteFieldName("start time");
writer.WriteStringValue(trace.StartTime.ToString("hh:mm:ss:fff"));

if (isRootTrace)
{
writer.WriteFieldName("start time");
writer.WriteStringValue(trace.StartTime.ToString("hh:mm:ss:fff"));
}
writer.WriteFieldName("duration in milliseconds");
writer.WriteNumber64Value(trace.Duration.TotalMilliseconds);

Expand Down
21 changes: 0 additions & 21 deletions ...Tests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
<Json><![CDATA[{
"Summary": {},
"name": "ExecuteAsync",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"data": {
Expand All @@ -70,59 +69,41 @@
"children": [
{
"name": "Execute Next Batch",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"children": [
{
"name": "Create Batch Request",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0
},
{
"name": "Execute Batch Request",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"children": [
{
"name": "Microsoft.Azure.Cosmos.Handlers.RequestInvokerHandler",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"children": [
{
"name": "Microsoft.Azure.Cosmos.Handlers.DiagnosticsHandler",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"data": {
"System Info": "Redacted To Not Change The Baselines From Run To Run"
},
"children": [
{
"name": "Microsoft.Azure.Cosmos.Handlers.RetryHandler",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"children": [
{
"name": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"children": [
{
"name": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"children": [
{
"name": "Microsoft.Azure.Documents.ServerStoreModel Transport Request",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0,
"data": {
"Client Side Request Stats": "Redacted To Not Change The Baselines From Run To Run"
Expand All @@ -140,8 +121,6 @@
},
{
"name": "Create Trace",
"id": "00000000-0000-0000-0000-000000000000",
"start time": "12:00:00:000",
"duration in milliseconds": 0
}
]
Expand Down
Loading