Trace: Fixes Tracing/diagnostics hour-times to 24Hours #3558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ealsur
reviewed
Nov 11, 2022
| writer.Write(space); | ||
|
|
||
| writer.Write(trace.StartTime.ToString("hh:mm:ss:fff", CultureInfo.InvariantCulture)); | ||
| writer.Write(trace.StartTime.ToString(TraceWriter.HourTimeFormatString, CultureInfo.InvariantCulture)); |
Member
There was a problem hiding this comment.
Is Compute depending on this format for anything?
Member
Author
There was a problem hiding this comment.
Unsure but its incorrect right?
Member
There was a problem hiding this comment.
True but my point is, if they currently have any automation component parsing/interpreting this, this change might break it if they assume no values > 12. Probably not going to happen, but it's worth at least calling it out on the PR description and sending them a heads-up?
Member
Author
There was a problem hiding this comment.
Please check #3577
Got into rebase issues and ended-up re-creating a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber