Open Telemetry Traces: Fixes filtering of event on 404/0 or similar non failure status codes #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly for the allowed status and substatuscode
sourabh1007
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
philipthomas-MSFT
approved these changes
Oct 8, 2024
Contributor
philipthomas-MSFT
left a comment
philipthomas-MSFT
left a comment
There was a problem hiding this comment.
LGTM although more context on this is encouraged.
kirankumarkolli
approved these changes
Oct 8, 2024
This was referenced Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check on Cosmos Exception to make sure events are generated only for the allowed status and substatuscode
Type of change
Closing issues
To automatically close an issue: closes #4735