Open Telemetry: Fixes attribute name as per OTel Guidance #4995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
NaluTripician
approved these changes
Feb 5, 2025
Contributor
NaluTripician
left a comment
NaluTripician
left a comment
There was a problem hiding this comment.
Could you please update the PR description explaining why the semantic changes need to happen for others looking at this PR in the future. Other than that, LGTM.
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/CosmosDbClientMetrics.cs
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Feb 6, 2025
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/otelattr
branch
This was referenced Jul 28, 2025
Closed
This was referenced Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
For Open Telemetry, we got new semantic conventions from Otel Community to follow.
Hence, as part of this PR, making changes accordingly.
db.client.cosmosdbtoazure.cosmosdb.client(for attributes and metrics)db.system=>db.system.namedb.cosmosdb.client_id=>azure.cosmosdb.client.iddb.cosmosdb.connection_mode=>azure.cosmosdb.connection.modedb.cosmosdb.request_content_length=>azure.cosmosdb.request.body.sizedb.cosmosdb.response_content_length=>azure.cosmosdb.response.body.sizedb.cosmosdb.regions_contacted=>azure.cosmosdb.contacted_regionsdb.cosmosdb.row_count=>azure.cosmosdb.row.countdb.cosmosdb.consistency_level=>azure.cosmosdb.consistency.levelType of change