-
Notifications
You must be signed in to change notification settings - Fork 236
Unwrap golobby errors and check for container error #5205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Fixes #5198
Before upgrading the
golobby/container
package the package was not wrapping errors when there was a container resolution failure.Root Cause golobby change:
golobby/container@v3.3.1...master#diff-14bacfb63a209323729af295c64c9bb978c84e810d18e3e7b7ae66d9b3cd7acaL242
With the recent update the are wrapping all errors and now we need to unwrap the error to determine if the root error was still a container related configuration issue or another error returns by the component initializer/constructor.
We are also able to revert the previous change that was not a full fix for the original issue:
https://github.com/Azure/azure-dev/pull/5065/files#diff-b03e5b88fe3c56354b85e98942a63eff1755fe891f4ccc81ead0088a6f52577eL52