-
Notifications
You must be signed in to change notification settings - Fork 236
vs aspire integration service name support #5249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vs aspire integration service name support #5249
Conversation
…or one service. - Updated formatting for consistency in AcceptanceTests.cs, including spacing and braces. - Added a new test method LiveDeployServiceRefresh to AcceptanceTests.cs to validate service deployment and refresh functionality. - Enhanced IEnvironmentService interface by adding DeployServiceAsync method to support service deployment operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for deploying a single service via a new DeployServiceAsync
RPC, updates related CLI flags, and augments functional tests to cover the new behavior.
- Introduced
DeployServiceAsync
inIEnvironmentService
and wired it through the VS-Server RPC layer. - Refactored
DeployAsync
to delegate to the new single‐service logic. - Extended functional tests (
LiveDeployServiceRefresh
) and updated recorded test fixtures.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
cli/azd/test/functional/testdata/vs-server/tests/AzdServices.cs | Added DeployServiceAsync to IEnvironmentService interface |
cli/azd/test/functional/testdata/vs-server/tests/AcceptanceTests.cs | Expanded formatting and added new LiveDeployServiceRefresh test |
cli/azd/test/functional/testdata/recordings/Test_CLI_VsServer/LiveDeployServiceRefresh.dotnet.yaml | New recording for service‐specific deploy |
cli/azd/test/functional/testdata/recordings/Test_CLI_VsServer/LiveDeployRefresh.dotnet.yaml | Updated paths and tags in existing recording |
cli/azd/internal/vsrpc/environment_service_deploy_service.go | Implemented DeployServiceAsync combining provision + deploy |
cli/azd/internal/vsrpc/environment_service_deploy.go | Refactored DeployAsync to forward to DeployServiceAsync |
cli/azd/internal/vsrpc/environment_service.go | Registered DeployServiceAsync handler |
cli/azd/internal/cmd/util.go | Removed obsolete serviceNameWarningCheck utility |
cli/azd/internal/cmd/deploy.go | Exported ServiceName flag and cleaned up deprecation warning |
cli/azd/test/functional/testdata/vs-server/tests/AzdServices.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
very exciting! |
Adding
DeployServiceAsync
to VS-Server to allow deploying one service instead of all services.fix: #5125