Skip to content

Support Long Timers for Out of Proc Languages ⏳📈🚀 #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 12, 2022

Conversation

hossam-nasr
Copy link
Contributor

@hossam-nasr hossam-nasr commented Apr 9, 2022

This PR:

  • Adds support for long timers for out-of-proc SDKs
  • Adds a new schema version (to signify SDK support for long timers)
  • Only allows OOProc to use the long timer API if using the new schema version

Issue describing the changes in this PR

Extension-side of resolving Azure/azure-functions-durable-js#325. JS SDK PR: Azure/azure-functions-durable-js#340

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs

@hossam-nasr hossam-nasr changed the title Hossamnasr/long timer ooproc Support Long Timers for Out of Proc Languages ⏳📈🚀 Apr 9, 2022
@hossam-nasr hossam-nasr marked this pull request as ready for review April 9, 2022 01:06
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mostly looks good to me, but I left a few nits.
The only reason I'm not approving at this point is that AssemblyInfo change. What that change on purpose? If so, can you please explain it? Otherwise, I'd try removing it and making sure it all still works. Thanks!

@hossam-nasr hossam-nasr force-pushed the hossamnasr/long-timer-ooproc branch from f85e546 to acae086 Compare April 11, 2022 22:45
@hossam-nasr hossam-nasr added the out-of-proc Impacts non-.NET languages (e.g. JavaScript, Python, or PowerShell) which execute out-of-process label Apr 11, 2022
@hossam-nasr hossam-nasr force-pushed the hossamnasr/long-timer-ooproc branch from 4974d40 to 863d7ce Compare April 11, 2022 23:28
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
Thank you for this work, our users will really appreciate this change. As always, squash and merge, then delete branch :)

@hossam-nasr hossam-nasr merged commit d5cdaf3 into dev Apr 12, 2022
@hossam-nasr hossam-nasr deleted the hossamnasr/long-timer-ooproc branch April 12, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out-of-proc Impacts non-.NET languages (e.g. JavaScript, Python, or PowerShell) which execute out-of-process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants