-
Notifications
You must be signed in to change notification settings - Fork 276
Support Long Timers for Out of Proc Languages ⏳📈🚀 #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It mostly looks good to me, but I left a few nits.
The only reason I'm not approving at this point is that AssemblyInfo
change. What that change on purpose? If so, can you please explain it? Otherwise, I'd try removing it and making sure it all still works. Thanks!
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableOrchestrationContext.cs
Outdated
Show resolved
Hide resolved
f85e546
to
acae086
Compare
4974d40
to
863d7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work, our users will really appreciate this change. As always, squash and merge, then delete branch :)
This PR:
Issue describing the changes in this PR
Extension-side of resolving Azure/azure-functions-durable-js#325. JS SDK PR: Azure/azure-functions-durable-js#340
Pull request checklist
pending_docs.md
release_notes.md
/src/Worker.Extensions.DurableTask/AssemblyInfo.cs