Skip to content

npm audit fix on /samples and /samples/UnitTesting #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2022
Merged

npm audit fix on /samples and /samples/UnitTesting #343

merged 2 commits into from
Apr 11, 2022

Conversation

hossam-nasr
Copy link
Contributor

No description provided.

@hossam-nasr hossam-nasr changed the title npm audit fix on /samples npm audit fix on /samples and /samples/UnitTesting Apr 11, 2022
davidmrdavid
davidmrdavid approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, thanks for updating the samples.
lgtm!

@hossam-nasr hossam-nasr merged commit 3182ada into dev Apr 11, 2022
@hossam-nasr hossam-nasr deleted the hossamnasr/npm-audit-fix-samples branch April 11, 2022 22:58
@hossam-nasr hossam-nasr mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hossam-nasr @davidmrdavid