Skip to content

Remove moment types from exported types #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

Remove moment types from exported types #354

merged 1 commit into from
Apr 28, 2022

Conversation

hossam-nasr
Copy link
Contributor

@hossam-nasr hossam-nasr commented Apr 27, 2022 •
edited
Loading

Partially addresses #353 . Removes the moment.Duration type from the LongTimerTask constructor.

@hossam-nasr hossam-nasr mentioned this pull request Apr 27, 2022
Merged
davidmrdavid
davidmrdavid approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@hossam-nasr hossam-nasr merged commit 08f0d6b into dev Apr 28, 2022
@hossam-nasr hossam-nasr deleted the hossamnasr/remove-moment branch April 28, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hossam-nasr @davidmrdavid