-
Notifications
You must be signed in to change notification settings - Fork 476
Tagging cold start impacted requests #11542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements tagging for cold start impacted requests by introducing OpenTelemetry activity tracking during host specialization. The changes move cold start tagging from the request execution phase to the host initialization phase, providing better observability for concurrent requests affected by cold starts.
Key Changes:
- Introduces
ActivityExtensionsclass with methods to create and tag specialization activities - Updates
StandbyManagerto create and tag activities during host specialization - Removes previous cold start tagging logic from
FunctionExecutionFeature
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/WebJobs.Script/Diagnostics/OpenTelemetry/ActivityExtensions.cs |
New extension methods for creating specialization activities and tagging cold starts |
src/WebJobs.Script.WebHost/Standby/StandbyManager.cs |
Tags activities during specialization with cold start information |
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConstants.cs |
Adds constants for new activity source name and specialization operation |
src/WebJobs.Script/Diagnostics/OpenTelemetry/ResourceSemanticConventions.cs |
Adds constant for cold start impacted tag |
src/WebJobs.Script/ScriptHostBuilderExtensions.cs |
Updates activity source registration to use WebJobs-specific constants |
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs |
Adds new activity source to tracing configuration |
src/WebJobs.Script.WebHost/Features/FunctionExecutionFeature.cs |
Removes old cold start activity tagging |
test/WebJobs.Script.Tests/StandbyManagerTests.cs |
Adds comprehensive tests for specialization activity creation and tagging |
release_notes.md |
Documents the new feature |
Issue describing the changes in this PR
resolves #11543
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information