-
Notifications
You must be signed in to change notification settings - Fork 476
Stop collecting telemetry from admin endpoint requests #11544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies OpenTelemetry telemetry collection by excluding all admin endpoint requests instead of filtering specific admin paths. The change consolidates multiple path-specific exclusions into a single, broader filter.
Key Changes:
- Simplified telemetry filtering to exclude all
/adminpaths instead of specific endpoints - Fixed variable name shadowing in
ConfigureMetricsandConfigureTracingmethods
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs | Replaced multiple specific admin path exclusions with a single filter for all /admin paths; renamed shadowed lambda parameters to meterProviderBuilder and traceProviderBuilder |
| release_notes.md | Added release note entry for the telemetry collection change |
|
@RohitRanjanMS I've opened a new pull request, #11546, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@RohitRanjanMS are you certain there is no admin endpoint that is valuable for the customer to track? |
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
|
@jviau , some of the admin endpoints are still useful, so I brought back the previous filters and just added /admin/host/ping to the list |
Issue describing the changes in this PR
resolves #11545
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information