Skip to content

Emit diagnostic event upon Host Id collision #9061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 2, 2023
Merged

Emit diagnostic event upon Host Id collision #9061

merged 15 commits into from
Feb 2, 2023

Conversation

madelinegordon
Copy link
Contributor

@madelinegordon madelinegordon commented Jan 31, 2023 •
edited
Loading

Issue describing the changes in this PR

resolves #8949

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
      Added documentation here
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@madelinegordon madelinegordon marked this pull request as ready for review January 31, 2023 21:58
@madelinegordon madelinegordon requested a review from a team as a code owner January 31, 2023 21:58
liliankasem
liliankasem reviewed Jan 31, 2023
View reviewed changes
kashimiz
kashimiz reviewed Feb 1, 2023
View reviewed changes
@madelinegordon madelinegordon merged commit e3eaa72 into dev Feb 2, 2023
@madelinegordon madelinegordon deleted the magordon/hostidcollision branch February 2, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surgupta-msft surgupta-msft surgupta-msft left review comments

@liliankasem liliankasem liliankasem approved these changes

@kashimiz kashimiz kashimiz approved these changes

@satvu satvu satvu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host ID collision error should be a diagnostic event
5 participants
@madelinegordon @liliankasem @surgupta-msft @kashimiz @satvu