Skip to content

fix function name issue #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix function name issue #447

wants to merge 1 commit into from

Conversation

kaibocai
Copy link
Member

Fix the issue that function cannot have same method name as any other method in it's parent class.

@kaibocai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@TsuyoshiUshio TsuyoshiUshio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding out this issue.
For the change, Looks good to me. However, The CI fails by the other reason. Could you find the reason why it fails?
Once CI has passed, I'd happy to approve this change.

@kaibocai
Copy link
Member Author

Thank you for finding out this issue.
For the change, Looks good to me. However, The CI fails by the other reason. Could you find the reason why it fails?
Once CI has passed, I'd happy to approve this change.

Hi @TsuyoshiUshio, yes currently trying to identify the reason and will get it resolved. Thanks.

@kaibocai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kaibocai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kaibocai kaibocai closed this Sep 20, 2021
@kaibocai kaibocai deleted the v4_kc_fix_method_same_name branch May 24, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants