-
Notifications
You must be signed in to change notification settings - Fork 65
Gracefully shutdown worker on WorkerTerminate request #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @liliankasem , just to confirm that host will restart after it send out WorkerTerminate request to language worker right. Do we long how many time we got between WorkerTerminate request send out and host restart? Thanks. |
Grace period is set here, which I believe is currently 5 seconds @surgupta-msft can confirm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some minor comments.
src/main/java/com/microsoft/azure/functions/worker/handler/WorkerInitRequestHandler.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/Application.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/Application.java
Outdated
Show resolved
Hide resolved
81afff6
to
a3c416c
Compare
a3c416c
to
7f3e99e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/main/java/com/microsoft/azure/functions/worker/WorkerLogManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/WorkerLogManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue describing the changes in this PR
resolves #630 Azure/azure-functions-host#2308 Azure/azure-functions-host#3296
attached design doc: https://dev.azure.com/msazure/One/_git/AAPT-Antares-Docs?path=/TeamDocs/FunctionTeamDocs/Design/OOPWorkers/GracefulShutdownOfWorker.md&_a=preview&anchor=out-of-proc-support-for-cancellation-tokens
The flow would be the following:
Pull request checklist
release_notes.md