Add basic hook support #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
reviewed
Nov 2, 2023
castrodd
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports app start, app terminate, pre invocation, and post invocation hooks. Fixes #7
To see example code, check out the end-to-end tests I added here in
app/v4/src/index.ts. I also added unit tests in this repo, but they're less meaningful (they mainly ensure hooks are unit-testable by our users as well).Loosely based off Hossam's work in #115, which has been delayed a lot. I think part of the delay was from feature-creep, so my focus is just to get the MVP out and I don't have any plans to add all the extra features at this time. I'm super excited about hooks even in MVP-form and I think our users will be, too.