Skip to content

Updating the undici Major Version #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

Updating the undici Major Version #350

merged 3 commits into from
Jun 9, 2025

Conversation

swapnil-nagar
Copy link
Contributor

No description provided.

@swapnil-nagar swapnil-nagar requested a review from a team as a code owner June 4, 2025 17:57
@hallvictoria hallvictoria merged commit c543818 into v4.x Jun 9, 2025
12 checks passed
@hallvictoria hallvictoria deleted the updateUndiciMajorVersion branch June 9, 2025 19:18
@BridgeAR
Copy link

BridgeAR commented Jun 27, 2025 •
edited
Loading

This breaks Node.js 18 support, due to unidici 7 only supporting Node.js 20 and above. Latest undici 6 supports >=18.17, while the latest undici release that had full Node.js 18 support is 6.13.0. Since 6.13.0 is vulnerable, I would just plainly revert this commit.

BridgeAR added a commit to BridgeAR/azure-functions-nodejs-library that referenced this pull request Jun 27, 2025
@BridgeAR
Revert "Updating the undici Major Version (Azure#350)"
ecccb06 
This reverts commit c543818.

The support range for undici in newer versions does not match the
current @azure/functions support range.

The original commit broke Node.js 18 support, due to unidici 7 only
supporting Node.js 20 and above. Latest undici supports >=18.17,
while the latest undici release that had full Node.js 18 support is
v6.13.0. Since v6.13.0 has known security issues, it's just a plain
revert.
@BridgeAR BridgeAR mentioned this pull request Jun 27, 2025
Open
@swapnil-nagar
Copy link
Contributor Author

This breaks Node.js 18 support, due to unidici 7 only supporting Node.js 20 and above. Latest undici supports >=18.17, while the latest undici release that had full Node.js 18 support is 6.13.0. Since 6.13.0 is vulnerable, I would just plainly revert this commit.

I really want to thank you for surfacing the issue and we have deprecated the 4.7.3 version.

@timtucker-dte
Copy link

This breaks Node.js 18 support, due to unidici 7 only supporting Node.js 20 and above. Latest undici supports >=18.17, while the latest undici release that had full Node.js 18 support is 6.13.0. Since 6.13.0 is vulnerable, I would just plainly revert this commit.

I really want to thank you for surfacing the issue and we have deprecated the 4.7.3 version.

For clarity, given that Node 18 is no longer a supported runtime for Azure Functions why does it matter if newer versions of this library no longer support it?

https://learn.microsoft.com/en-us/azure/azure-functions/functions-versions?tabs=isolated-process%2Cv4&pivots=programming-language-javascript

July 10, 2025 is the end of support date for other Azure SDKs, so it's not unreasonable to be dropping support here as well:
https://devblogs.microsoft.com/azure-sdk/announcing-the-end-of-support-for-node-js-18-x-in-the-azure-sdk-for-javascript/

@BridgeAR
Copy link

The library itself just defines a different support range. I can actually not judge much upon the impact.
I guess with Node.js 18 support being dropped, a new major would be released?

@BridgeAR
Copy link

I really want to thank you for surfacing the issue and we have deprecated the 4.7.3 version.

You're welcome, I hope I was indeed of help and it's not too much work handling the deprecated version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallvictoria hallvictoria hallvictoria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swapnil-nagar @BridgeAR @timtucker-dte @hallvictoria