How to access OpenApiConfigurationOptions from within the TypeVisitors

[rockgecko-development]

For #451 , I want to be able to access the OpenApiConfigurationOptions from within the TypeVisitors. What's the best way to do that? The only way forward I can currently see is to rewire the Activator.CreateInstance calls:

azure-functions-openapi-extension/src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/VisitorCollection.cs

Line 53 in 982ad22

.Select(p => (IVisitor)Activator.CreateInstance(p, collection)).ToList(); // NOTE: there is no direct enforcement on the constructor arguments of the visitors

to pass OpenApiConfigurationOptions as a constructor param.

Should I just do that?

[justinyoo]

There are two places you need to inject the IOpenApiConfigurationOptions:

azure-functions-openapi-extension/src/Microsoft.Azure.Functions.Worker.Extensions.OpenApi/OpenApiHttpTriggerContext.cs

Lines 173 to 178 in 4e81588

	public virtual VisitorCollection GetVisitorCollection()
	{
	var collection = VisitorCollection.CreateInstance();
	return collection;
	}

azure-functions-openapi-extension/src/Microsoft.Azure.WebJobs.Extensions.OpenApi/OpenApiHttpTriggerContext.cs

Lines 172 to 177 in 4e81588

	public virtual VisitorCollection GetVisitorCollection()
	{
	var collection = VisitorCollection.CreateInstance();
	return collection;
	}

The IOpenApiConfigurationOptions instance already exists as a private field in there.

However, there are two other places as well:

azure-functions-openapi-extension/src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Extensions/OpenApiParameterAttributeExtensions.cs

Lines 37 to 40 in 4e81588

	if (collection.IsNullOrDefault())
	{
	collection = VisitorCollection.CreateInstance();
	}

azure-functions-openapi-extension/src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Extensions/OpenApiPayloadAttributeExtensions.cs

Lines 37 to 40 in 4e81588

	if (collection.IsNullOrDefault())
	{
	collection = VisitorCollection.CreateInstance();
	}

---

The first two xxxContext instances look fine, but the latter two looks complicated. Can we do this for v2.0.0 release, rather than the current v1.x release?