E2e test suite from Nodejs worker #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
daxian-dbw,
SteveL-MSFT,
pragnagopa and
maiqbal11
|
cc @anirudhgarg @paulbatum @fabiocav for awareness |
pragnagopa
reviewed
Jan 28, 2019
pragnagopa
approved these changes
Jan 29, 2019
TylerLeonhardt
force-pushed
the
e2e-test-suite
branch
from
37b7596 to
4c78f7f
Compare
TylerLeonhardt
force-pushed
the
e2e-test-suite
branch
from
82f4c23 to
74b5601
Compare
|
I'm going to merge these in. Feel free to give me feedback when you get back @daxian-dbw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here was to use the same test suite as Nodejs so that we can later refactor to a separate project used by all workers.
This does just that - with ZERO functional changes to the tests (only string changes for different resource names)
These tests work against actual Azure resources.
I figured folks wouldn't want to run e2e locally, so they will only run in CI
resolves #75