Skip to content

Use ConvertFromJson/ConvertToJson APIs directly #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2019

Conversation

daxian-dbw
Copy link
Contributor

JsonObject.ConvertToJson API was added in preview.4. The reference assembly for Microsoft.PowerShell.Commands.Utility.dll was also added in the SDK nuget package for preview.4, so we can use JsonObject.ConvertFromJson and JsonObject.ConvertToJson directly.

@TylerLeonhardt
Copy link
Member

This feels so good 😊

@daxian-dbw
Copy link
Contributor Author

Sorry that I didn't get enough time to get it right in the first attempt :) I hope the CI will pass this time.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@TylerLeonhardt TylerLeonhardt merged commit a998cbc into Azure:dev Feb 2, 2019
@daxian-dbw daxian-dbw deleted the json branch February 7, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants