added build scripts and pester tests #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Sep 10, 2018
build.ps1
Outdated
| @@ -0,0 +1,87 @@ | |||
| #!/usr/bin/env pwsh | |||
| param( | |||
There was a problem hiding this comment.
Forgot header oops
TylerLeonhardt
commented
Sep 10, 2018
TylerLeonhardt
commented
Sep 10, 2018
daxian-dbw
reviewed
Sep 10, 2018
|
|
||
| # Remove the built nuget package | ||
| Remove-Item -Recurse -Force package/bin -ErrorAction SilentlyContinue | ||
| Remove-Item -Recurse -Force package/obj -ErrorAction SilentlyContinue |
There was a problem hiding this comment.
why not git clean -fdx?
|
|
||
| task Build { | ||
| exec { dotnet build } | ||
| exec { dotnet publish } |
There was a problem hiding this comment.
Can we pass in the configuration to use for the build and publish?
| } | ||
|
|
||
| task Test { | ||
| Set-Location test |
There was a problem hiding this comment.
You are assuming $pwd is at the root folder, is that a safe assumption? This is the case in other tasks too.
There was a problem hiding this comment.
This is assumed because InvokeBuild sets the location to whatever BuildRoot is set to:
https://github.com/nightroman/Invoke-Build/wiki/Build-Scripts-Guidelines#use-the-default-or-custom-buildroot
test/Modules/Microsoft.Azure.Functions.PowerShellWorker.Tests.ps1
Outdated
Show resolved
Hide resolved
test/Modules/Microsoft.Azure.Functions.PowerShellWorker.Tests.ps1
Outdated
Show resolved
Hide resolved
daxian-dbw
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 things:
You can invoke the build script in many ways:
build.ps1- just buildsbuild.ps1 -Clean- Cleans and buildsbuild.ps1 -Bootstrap- tells you what dependencies you are missingbuild.ps1 -Test- Builds and tests both xunit and Pester