-
Notifications
You must be signed in to change notification settings - Fork 54
add psm1 support #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add psm1 support #46
Conversation
Question for the room... should I ALSO add psd1 so that a user can use a module manifest? |
It feels to me not useful to allow |
@daxian-dbw I think I'm confused by what you're saying. Why do we need to make the association between This gives them the ability to expose that entry point using |
I don't understand how the .psm1 will get used with AzF. Does this simply mean treating a .psm1 as a .ps1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given our discussion with @joeyaiello, shall we defer the support to .psm1
files?
@SteveL-MSFT Users are allowed to specify the |
Yeah we can defer this for now, but Dongbo gave good context as to what this is all about. |
@daxian-dbw I can see how it's possible, but I don't see the value as it adds complexity for the user |
@SteveL-MSFT We got the same feedback from @joeyaiello when talking to him about this, and decided to put off this change until it's asked by the user. |
I'm going to defer any fancy entry point checking for #15
This allows a user to use a psm1 - they just need to make sure they specify an entrypoint and export that module member.
fixes #46