Switch from Grpc.Core to Grpc.Net.Client (#758) #766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpeng36
force-pushed
the
michaelpeng/grpc-dotnet-v4xps70
branch
from
d7134d9 to
6325d0d
Compare
|
Hello @michaelpeng36 -- We should get this change in by 6/1/22, so that this can be included in the next worker release and Functions deployment. Do you know if we need this change is needed for the Core Tools M1 build? |
|
Since this is targeting the 7.0 branch, it does not matter for M1 support. PowerShell 7.2 was the first version to support M1, and anything earlier won't work regardless of what we do on the Functions side |
* Upgraded protobuf versions and removed Grpc.Core dependency * Updated channel and option types used * Change channel credentials * Added http prefix to url * Add valid URL check and explicitly include credentials
michaelpeng36
force-pushed
the
michaelpeng/grpc-dotnet-v4xps70
branch
from
fc65887 to
f9b38d3
Compare
|
Closing, as this affected the host's ability to start the PowerShell worker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Cherry-pick of #758. Resolves #751 for
v4.x/ps7.0.Pull request checklist
release_notes.md