Skip to content

build: move library release to internal #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Mar 18, 2025

Migrate library release pipeline to 1ES.

@hallvictoria hallvictoria marked this pull request as ready for review March 18, 2025 23:06
@gavin-aguiar gavin-aguiar merged commit 1ff7844 into dev Mar 20, 2025
16 checks passed
@gavin-aguiar gavin-aguiar deleted the hallvictoria/library-release branch March 20, 2025 21:09
Comment on lines +15 to +21
sdl:
codeql:
compiled:
enabled: true # still only runs for default branch
runSourceLanguagesInSourceAnalysis: true
settings:
skipBuildTagsForGitHubPullRequests: ${{ variables['System.PullRequest.IsFork'] }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may not be required for release pipeline

build tags were being skipped for public build since we needed to run public build from fork PRs.
code ql should only run on build pipeline, are we building anything again in this pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CodeQL, the pipeline is not building anything, but it is downloading a build artifact from another pipeline. Can CodeQL be skipped in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we don't need to add it. Also, official templates take care of adding itself if required.

template: v1/1ES.Official.PipelineTemplate.yml@1es
parameters:
pool:
name: 1es-pool-azfunc-public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipelines in internal repo using official templates should use pool - 1es-pool-azfunc to separate internal and public workload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants