SettingsApi ModuleNotFoundError fix when extensions enabled#1305
Merged
gavin-aguiar merged 19 commits intodevfrom Aug 25, 2023
Merged
SettingsApi ModuleNotFoundError fix when extensions enabled#1305gavin-aguiar merged 19 commits intodevfrom
gavin-aguiar merged 19 commits intodevfrom
Conversation
gavin-aguiar
requested review from
YunchuWang,
pdthummar and
vrdmr
as code owners
gavin-aguiar
force-pushed
the
gaaguiar/testing_extensions
branch
from
6e21519 to
2bf3688
Compare
gavin-aguiar
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1305 +/- ##
===========================================
- Coverage 85.00% 32.15% -52.86%
===========================================
Files 34 34
Lines 1914 1922 +8
Branches 363 366 +3
===========================================
- Hits 1627 618 -1009
- Misses 221 1303 +1082
+ Partials 66 1 -65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
August 17, 2023 16:51
vrdmr
reviewed
Aug 17, 2023
added 12 commits
August 18, 2023 12:30
vrdmr
reviewed
Aug 25, 2023
| self.assertEqual(resp.status_code, 200) | ||
| self.assertIn("Func Version: 1.11.1", resp.text) | ||
|
|
||
| @skipIf(sys.version_info.minor != 10, |
Member
There was a problem hiding this comment.
Do we want the same for 3.9? and see what the experience is?
Contributor
Author
There was a problem hiding this comment.
Not needed. It should have the same behavior since extensions is enabled in this test.
vrdmr
reviewed
Aug 25, 2023
vrdmr
requested changes
Aug 25, 2023
vrdmr
approved these changes
Aug 25, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the try_get_sdk method to avoid popping azure.functions from sys.modules.
This was causing ImportError: cannot import name 'SettingsApi'
Instead now we add python_packages to sys path and then import azure.functions so that we always get the sdk from the customers library.
Other changes:
Refactored dispatcher.py to improve logging.
Fixes #1304
PR information
Quality of Code and Contribution Guidelines