-
Notifications
You must be signed in to change notification settings - Fork 107
feat: Adding support for python 3.13 #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 28 commits
a1fb445
4d3b892
a6c80f1
5343e0e
d1390d5
bcad815
f720195
f7f4795
43d29a3
bcdf819
bc4a520
7c7cc36
4764ce7
53a3d4e
5caa922
357ed59
dabaec6
7f038bb
3ff686d
5ade8e3
c465406
6083d7f
be60b01
2992d42
dc94eb1
fb5a154
66175ce
f439425
fb1823c
4ac586f
f6b6551
1e7e732
b364962
3b1f961
4de671d
b376b46
2419e78
661de36
7fccc3a
df125fd
9613706
c9be882
5ac75e1
2429bdd
b841184
dec9d34
0873832
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
/_src | ||
*_pb2.py | ||
*_pb2_grpc.py |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,9 @@ jobs: | |
Python312V4: | ||
pythonVersion: '3.12' | ||
workerPath: 'python/prodV4/worker.py' | ||
Python313V4: | ||
pythonVersion: '3.13' | ||
workerPath: 'python/proxyV4/worker.py' | ||
templateContext: | ||
outputParentDirectory: $(Build.ArtifactStagingDirectory) | ||
outputs: | ||
|
@@ -62,6 +65,9 @@ jobs: | |
Python312V4: | ||
pythonVersion: '3.12' | ||
workerPath: 'python/prodV4/worker.py' | ||
Python313V4: | ||
pythonVersion: '3.13' | ||
workerPath: 'python/proxyV4/worker.py' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can the worker Path be a variable at the top? |
||
templateContext: | ||
outputParentDirectory: $(Build.ArtifactStagingDirectory) | ||
outputs: | ||
|
@@ -100,6 +106,9 @@ jobs: | |
Python312V4: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the long run - We should simplify these blocks - the yaml is unnecessarily long. |
||
pythonVersion: '3.12' | ||
workerPath: 'python/prodV4/worker.py' | ||
Python313V4: | ||
pythonVersion: '3.13' | ||
workerPath: 'python/proxyV4/worker.py' | ||
templateContext: | ||
outputParentDirectory: $(Build.ArtifactStagingDirectory) | ||
outputs: | ||
|
@@ -137,6 +146,9 @@ jobs: | |
Python312V4: | ||
pythonVersion: '3.12' | ||
workerPath: 'python/prodV4/worker.py' | ||
Python313V4: | ||
pythonVersion: '3.13' | ||
workerPath: 'python/proxyV4/worker.py' | ||
templateContext: | ||
outputParentDirectory: $(Build.ArtifactStagingDirectory) | ||
outputs: | ||
|
@@ -168,6 +180,9 @@ jobs: | |
Python312V4: | ||
pythonVersion: '3.12' | ||
workerPath: 'python/prodV4/worker.py' | ||
Python313V4: | ||
pythonVersion: '3.13' | ||
workerPath: 'python/proxyV4/worker.py' | ||
templateContext: | ||
outputParentDirectory: $(Build.ArtifactStagingDirectory) | ||
outputs: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,15 @@ jobs: | |
SQL_CONNECTION: $(LinuxSqlConnectionString312) | ||
EVENTGRID_URI: $(LinuxEventGridTopicUriString312) | ||
EVENTGRID_CONNECTION: $(LinuxEventGridConnectionKeyString312) | ||
Python313: | ||
PYTHON_VERSION: '3.13' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3.13 is added to the E2E and emulator pipelines right now. E2E tests are re-using 312 resources for now until the appropriate 313 resources are created (cosmosdb, sql, eventgrid). Adding 3.13 to unit tests is pending still -- we don't want to run proxy worker tests for <=3.12, and vice versa. This will involve some more logic There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For this - is there a helper script to smoothen the process of creation? If not, please add it in the 3.13 backlog. |
||
STORAGE_CONNECTION: $(LinuxStorageConnectionString312) | ||
COSMOSDB_CONNECTION: $(LinuxCosmosDBConnectionString312) | ||
EVENTHUB_CONNECTION: $(LinuxEventHubConnectionString312) | ||
SERVICEBUS_CONNECTION: $(LinuxServiceBusConnectionString312) | ||
SQL_CONNECTION: $(LinuxSqlConnectionString312) | ||
EVENTGRID_URI: $(LinuxEventGridTopicUriString312) | ||
EVENTGRID_CONNECTION: $(LinuxEventGridConnectionKeyString312) | ||
steps: | ||
- task: UsePythonVersion@0 | ||
inputs: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,4 +13,10 @@ python -m invoke -c test_setup build-protos | |
|
||
cd .. | ||
cp .artifactignore "$BUILD_SOURCESDIRECTORY/deps" | ||
cp -r azure_functions_worker/protos "$BUILD_SOURCESDIRECTORY/deps/azure_functions_worker" | ||
|
||
version_minor=$(echo $1 | cut -d '.' -f 2) | ||
if [[ $version_minor -lt 13 ]]; then | ||
cp -r azure_functions_worker/protos "$BUILD_SOURCESDIRECTORY/deps/azure_functions_worker" | ||
else | ||
cp -r proxy_worker/protos "$BUILD_SOURCESDIRECTORY/deps/proxy_worker" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in the long run - the name shouldn't change - can it be done in this iteration itself? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As this seems unnecessary. |
||
fi |
hallvictoria marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. | ||
from proxy_worker import start_worker | ||
|
||
if __name__ == '__main__': | ||
start_worker.start() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why any change in this?