build: Add linux-arm64 build #1677
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallvictoria
changed the title
gavin-aguiar
reviewed
May 2, 2025
| matrix: | ||
| Python39V4: | ||
| pythonVersion: '3.9' | ||
| workerPath: 'python/prodV4/worker.py' |
There was a problem hiding this comment.
Can you move the worker path to a variable at the top?
This was one of the comments in the proxy worker PR
There was a problem hiding this comment.
I saw that comment. Thinking on this -- the issue is that workerPath is now different for Python 3.7-3.12 and 3.13+. It's not the same across the full Python matrix, so it can't be a top-level variable. We could look at removing this variable, but it would require some refactoring, and we'd have to add an if/else statement later to set this variable properly
There was a problem hiding this comment.
we could have 2 variables. proxyworkerpath and prodworkerpath
|
|
||
| - job: PackageWorkers | ||
| dependsOn: ['Build_WINDOWS_X64', 'Build_WINDOWS_X86', 'Build_LINUX_X64', 'Build_OSX_X64', 'Build_OSX_ARM64'] | ||
| dependsOn: ['Build_WINDOWS_X64', 'Build_WINDOWS_X86', 'Build_LINUX_X64', 'Build_OSX_X64', 'Build_OSX_ARM64', 'Build_LINUX_ARM64'] |
There was a problem hiding this comment.
Is there a Windows ARM64 arch too?
tests/extension_tests/deferred_bindings_tests/test_deferred_bindings.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1643
PR information
Quality of Code and Contribution Guidelines