feat: V2 library worker #1706
Open
feat: V2 library worker #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-aguiar
reviewed
Jul 2, 2025
| "grpcio~=1.70.0", | ||
| "grpcio-tools~=1.70.0", | ||
| "pytest-sugar", | ||
| "opentelemetry-api", # Used for OpenTelemetry unit tests |
There was a problem hiding this comment.
check if azure-monitor-opentelemetry installs opentelemetry-api. If it does then this can be removed
| ] | ||
|
|
||
| [project.urls] | ||
| Documentation = "https://github.com/Azure/azure-functions-python-worker/blob/hallvictoria/library-worker/README.md" |
There was a problem hiding this comment.
This is pointing to your branch
| | Runtime | Script Host & Language Extensibility | [File an Issue](https://github.com/Azure/azure-functions-host/issues) | | ||
| | VSCode | VSCode Extension for Azure Functions | [File an Issue](https://github.com/microsoft/vscode-azurefunctions/issues) | | ||
| | Core Tools | Command Line Interface for Local Development | [File an Issue](https://github.com/Azure/azure-functions-core-tools/issues) | | ||
| | Portal | User Interface or Experience Issue | [File an Issue](https://github.com/azure/azure-functions-ux/issues) | |
There was a problem hiding this comment.
Remove the portal item. The repo does not exist
| | Item | Description | Link | | ||
| |---------------|----------------------------------------------|--------------------------------------------------------------------------------| | ||
| | Python Worker | Programming Model, Triggers & Bindings | [File an Issue](https://github.com/Azure/azure-functions-python-worker/issues) | | ||
| | Linux | Base Docker Images | [File an Issue](https://github.com/Azure/azure-functions-docker/issues) | |
| from .utils.tracing import serialize_exception | ||
| from .utils.validators import validate_script_file_name | ||
|
|
||
| metadata_result: Optional[List] = None |
There was a problem hiding this comment.
add the _ for all variables.
| return is_false_like(os.environ[env_key]) | ||
|
|
||
|
|
||
| def get_app_setting( |
There was a problem hiding this comment.
We have an app setting manager. Can we move this there?
There was a problem hiding this comment.
Or somehow combine both?
| @@ -0,0 +1,295 @@ | |||
| # type: ignore | |||
There was a problem hiding this comment.
Should we add this as a dependency?
|
|
||
|
|
||
| @attach_message_to_exception( | ||
| expt_type=ImportError, |
There was a problem hiding this comment.
I think this needs to be fixed. It does not catch ModuleNotFound errors
| @@ -0,0 +1,2 @@ | |||
| # Required dependencies listed in pyproject.toml | |||
| jobs: | ||
| - template: /eng/templates/jobs/build.yml@self | ||
| parameters: | ||
| PYTHON_VERSION: '3.11' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds V2 library worker code.
Sample official build: https://dev.azure.com/azfunc/internal/_build/results?buildId=226215&view=results
Fixes #
Pull Request Checklist
Host-Worker Contract
Worker Execution Logic
If yes, please answer the following:
Python Version Coverage
Programming Model Compatibility (for Python 3.13+)