PowerShell NULL and function file updates #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasuBhog
requested review from
Charles-Gagnon,
lucyzhang929,
chlafreniere and
MaddyDev
as code owners
|
@VasuBhog please split this out into 2 different PRs |
VasuBhog
changed the title
| @@ -47,9 +47,6 @@ public void AddProductTest(int id, string name, int cost, SupportedLanguages lan | |||
| [SqlInlineData(1, "Test", 5)] | |||
| [SqlInlineData(0, "", 0)] | |||
| [SqlInlineData(-500, "ABCD", 580)] | |||
| // Currently PowerShell and Java functions return null when the parameter for name is an empty string | |||
| // Issue link: https://github.com/Azure/azure-functions-sql-extension/issues/443 | |||
| [UnsupportedLanguages(SupportedLanguages.PowerShell, SupportedLanguages.Java)] | |||
There was a problem hiding this comment.
These are still failing for Java it seems.
@lucyzhang929 - possibly a similar issue for their worker. So something to follow up with them about when you get around to investigating this.
lucyzhang929
approved these changes
Nov 28, 2022
Charles-Gagnon
approved these changes
Nov 28, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* null case test * update all powershell funcs to include triggermetadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443. As I found a current workaround using
$TriggerMetadataand followed up with a tracking issue in the powershell worker repo here.I also discussed with Francisco from the PowerShell team that we should use the latest worker version and include
$TriggerMetadatain our samples as it can be used instead of $Request as it is given as default in powershell azure functions. I added casting to some of the PowerShell functions in order to match precisely the same way we set them up from C# samples.I have root caused the issue with the
AddProductWithIdentitytests as there seems to be an issue with the GenerateDataQueryForMerge as the tests seem to generate theINSERT INTOvalues in the wrong order as how they are defined in the table. As such, there is a failure during the dotnet test. I will address this in the next PR.