add SqlClientListener for diagnostic logging #914
Conversation
MaddyDev
requested review from
Charles-Gagnon,
lucyzhang929,
chlafreniere and
VasuBhog
as code owners
|
|
||
| 3. Restart your function and reproduce your issue | ||
|
|
||
| 4. Get the log file and attach it to this issue. By default this will be in `%TMP%/LogFiles/Application/Functions/Host`. |
There was a problem hiding this comment.
Actually, looking at this it would be good to include instructions (for both this and the other logging message) for doing this in a deployed function too since they won't be the same. Not sure offhand what the easiest way to export the logs would be, so that might take some investigation.
In the meantime I think we can actually revert the change I had you add earlier about the Function App settings and instead specify that these instructions are for local development only. Then when we figure out a way for deployed functions we can come back and update both with those instructions.
There was a problem hiding this comment.
Thanks for adding the note! Might be worth making an actual issue to track updating this with instructions for deployed functions as well.
(although if we do that it might actually be best to just update the instructions in our docs and then link to those from here so we don't have to remember to keep both in sync)
|
|
||
| 3. Restart your function and reproduce your issue | ||
|
|
||
| 4. Get the log file and attach it to this issue. By default this will be in `%TMP%/LogFiles/Application/Functions/Host`. |
There was a problem hiding this comment.
Thanks for adding the note! Might be worth making an actual issue to track updating this with instructions for deployed functions as well.
(although if we do that it might actually be best to just update the instructions in our docs and then link to those from here so we don't have to remember to keep both in sync)
|
added #917 for us to track the hosted scenario docs. |
* add SqlClientListener * add const VerboseLogging * update var name * just log the event * move logging to client * add Needs Connection Logs label * remove unused telemetry * simplify logging * remove unused directive * add local deployment note
To enable the sql client logging, user needs to add the VerboseLogging and set it to true in config settings.
(Followed the implementation in sql tools service microsoft/sqltoolsservice#1544)
For #810