Skip to content

Conversation

@zhangeugenia
Copy link
Contributor

Description

Updates PnsCredential to invoke the correct setters when credential property names are returned in camelCase instead of PascalCase. When the properties are camelCase, the SDK attempts to invoke setters with a different casing when parsing NotificationHubDescriptions, resulting in various functions (such as getNotificationHub()) crashing.

Also:

  • Marks camelCase variant of setgoogleApiKey as deprecated
  • Updates JUnit to 5 to use ParameterizedTests

Things to consider before you submit the PR:

  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Related PRs or issues

Reported in Issue #169

@zhangeugenia zhangeugenia linked an issue Aug 8, 2023 that may be closed by this pull request
3 tasks
@zhangeugenia zhangeugenia changed the title Adds support for camelCase credential names Adds support for camelCase credential property names Aug 8, 2023
@zhangeugenia zhangeugenia merged commit a0e5f3b into main Aug 8, 2023
@zhangeugenia zhangeugenia deleted the fix-cred-setters branch August 8, 2023 22:53
zhangeugenia added a commit that referenced this pull request Aug 10, 2023
#170 Follow-up PR: Updating docstring & using Junit4
@zhangeugenia zhangeugenia mentioned this pull request Aug 11, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Get a notification hub by the hub path not working

4 participants