Skip to content

Conversation

@EldertGrootenboer
Copy link
Contributor

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use resourceGroup().location for resource locations
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@msftclas
Copy link

msftclas commented Sep 6, 2017

@EldertGrootenboer,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@bmoore-msft
Copy link
Collaborator

This passed CI, I queued another build trying to debug travis and that was the failure

},
"resources":[
{
"type":"Microsoft.ServiceBus/namespaces",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-order the properties on each resource to be consistent? It's hard to digest/review when the properties are in misc locations... e.g.

type
apiVersion
name
location
dependsOn

Copy link
Contributor Author

@EldertGrootenboer EldertGrootenboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties have been re-ordered

@bmoore-msft
Copy link
Collaborator

@EldertGrootenboer - it looks like they are all order consistently but not in the requested order, e.g.

type
apiVersion
name
location
dependsOn

Copy link
Contributor Author

@EldertGrootenboer EldertGrootenboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resorted according to requested order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants