-
Notifications
You must be signed in to change notification settings - Fork 16.3k
101 integrationpatterns messagerouter servicebus #3862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
101 integrationpatterns messagerouter servicebus #3862
Conversation
Use hyphen to combine prefix with uniquestring
|
@EldertGrootenboer, |
|
This passed CI, I queued another build trying to debug travis and that was the failure |
| }, | ||
| "resources":[ | ||
| { | ||
| "type":"Microsoft.ServiceBus/namespaces", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you re-order the properties on each resource to be consistent? It's hard to digest/review when the properties are in misc locations... e.g.
type
apiVersion
name
location
dependsOn
EldertGrootenboer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties have been re-ordered
|
@EldertGrootenboer - it looks like they are all order consistently but not in the requested order, e.g. type |
EldertGrootenboer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resorted according to requested order
Best Practice Checklist
Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md
For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md
Changelog